Sep 18, 2024 · Sep 5, 2024 · Sep 5, 2024 · Sep 5, 2024 · Sep 5, 2024 · Sep 6, 2024
diff --git a/cli/server.go b/cli/server.go
 "cdr.dev/slog"
 "cdr.dev/slog/sloggers/sloghuman"
 "github.com/coder/coder/v2/coderd/entitlements"
 "github.com/coder/coder/v2/coderd/notifications/reports"
 "github.com/coder/coder/v2/coderd/runtimeconfig"
 "github.com/coder/pretty"
 "github.com/coder/quartz"

 // nolint:gocritic // TODO: create own role.
 notificationsManager.Run(dbauthz.AsSystemRestricted(ctx))

 // Run report generator to distribute periodic reports.
 notificationReportGenerator := reports.NewReportGenerator(ctx, logger, options.Database, options.NotificationsEnqueuer, quartz.NewReal())
 defer notificationReportGenerator.Close()
 }

 // Wrap the server in middleware that redirects to the access URL if
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 return fetchWithPostFilter(q.auth, policy.ActionReadPersonal, q.db.GetExternalAuthLinksByUserID)(ctx, userID)
 }

 func (q *querier) GetFailedWorkspaceBuildsByTemplateID(ctx context.Context, arg database.GetFailedWorkspaceBuildsByTemplateIDParams) ([]database.GetFailedWorkspaceBuildsByTemplateIDRow, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 return nil, err
 }
 return q.db.GetFailedWorkspaceBuildsByTemplateID(ctx, arg)
 }

 func (q *querier) GetFileByHashAndCreator(ctx context.Context, arg database.GetFileByHashAndCreatorParams) (database.File, error) {
 file, err := q.db.GetFileByHashAndCreator(ctx, arg)
 if err != nil {
 return q.db.GetNotificationMessagesByStatus(ctx, arg)
 }

 func (q *querier) GetNotificationReportGeneratorLogByTemplate(ctx context.Context, arg uuid.UUID) (database.NotificationReportGeneratorLog, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 return database.NotificationReportGeneratorLog{}, err
 }
 return q.db.GetNotificationReportGeneratorLogByTemplate(ctx, arg)
 }

 func (q *querier) GetNotificationTemplateByID(ctx context.Context, id uuid.UUID) (database.NotificationTemplate, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
 return database.NotificationTemplate{}, err
 return q.db.GetWorkspaceBuildParameters(ctx, workspaceBuildID)
 }

 func (q *querier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
 if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
 return nil, err
 }
 return q.db.GetWorkspaceBuildStatsByTemplates(ctx, since)
 }

 func (q *querier) GetWorkspaceBuildsByWorkspaceID(ctx context.Context, arg database.GetWorkspaceBuildsByWorkspaceIDParams) ([]database.WorkspaceBuild, error) {
 if _, err := q.GetWorkspaceByID(ctx, arg.WorkspaceID); err != nil {
 return nil, err
 return q.db.UpsertLogoURL(ctx, value)
 }

 func (q *querier) UpsertNotificationReportGeneratorLog(ctx context.Context, arg database.UpsertNotificationReportGeneratorLogParams) error {
 if err := q.authorizeContext(ctx, policy.ActionCreate, rbac.ResourceSystem); err != nil {
 return err
 }
 return q.db.UpsertNotificationReportGeneratorLog(ctx, arg)
 }

 func (q *querier) UpsertNotificationsSettings(ctx context.Context, value string) error {
 if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceDeploymentConfig); err != nil {
 return err
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
 Value: "value",
 }).Asserts(rbac.ResourceSystem, policy.ActionCreate)
 }))
 s.Run("GetFailedWorkspaceBuildsByTemplateID", s.Subtest(func(db database.Store, check *expects) {
 check.Args(database.GetFailedWorkspaceBuildsByTemplateIDParams{
 TemplateID: uuid.New(),
 Since:      dbtime.Now(),
 }).Asserts(rbac.ResourceSystem, policy.ActionRead)
 }))
 s.Run("GetNotificationReportGeneratorLogByTemplate", s.Subtest(func(db database.Store, check *expects) {
 _ = db.UpsertNotificationReportGeneratorLog(context.Background(), database.UpsertNotificationReportGeneratorLogParams{
 NotificationTemplateID: notifications.TemplateWorkspaceBuildsFailedReport,
 LastGeneratedAt:        dbtime.Now(),
 })
 check.Args(notifications.TemplateWorkspaceBuildsFailedReport).Asserts(rbac.ResourceSystem, policy.ActionRead)
 }))
 s.Run("GetWorkspaceBuildStatsByTemplates", s.Subtest(func(db database.Store, check *expects) {
 check.Args(dbtime.Now()).Asserts(rbac.ResourceSystem, policy.ActionRead)
 }))
 s.Run("UpsertNotificationReportGeneratorLog", s.Subtest(func(db database.Store, check *expects) {
 check.Args(database.UpsertNotificationReportGeneratorLogParams{
 NotificationTemplateID: uuid.New(),
 LastGeneratedAt:        dbtime.Now(),
 }).Asserts(rbac.ResourceSystem, policy.ActionCreate)
 }))
 }

 func (s *MethodTestSuite) TestNotifications() {
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
 userLinks           []database.UserLink

 // New tables
 workspaceAgentStats           []database.WorkspaceAgentStat
 auditLogs                     []database.AuditLog
 cryptoKeys                    []database.CryptoKey
 dbcryptKeys                   []database.DBCryptKey
 files                         []database.File
 externalAuthLinks             []database.ExternalAuthLink
 gitSSHKey                     []database.GitSSHKey
 groupMembers                  []database.GroupMemberTable
 groups                        []database.Group
 jfrogXRayScans                []database.JfrogXrayScan
 licenses                      []database.License
 notificationMessages          []database.NotificationMessage
 notificationPreferences       []database.NotificationPreference
 oauth2ProviderApps            []database.OAuth2ProviderApp
 oauth2ProviderAppSecrets      []database.OAuth2ProviderAppSecret
 oauth2ProviderAppCodes        []database.OAuth2ProviderAppCode
 oauth2ProviderAppTokens       []database.OAuth2ProviderAppToken
 parameterSchemas              []database.ParameterSchema
 provisionerDaemons            []database.ProvisionerDaemon
 provisionerJobLogs            []database.ProvisionerJobLog
 provisionerJobs               []database.ProvisionerJob
 provisionerKeys               []database.ProvisionerKey
 replicas                      []database.Replica
 templateVersions              []database.TemplateVersionTable
 templateVersionParameters     []database.TemplateVersionParameter
 templateVersionVariables      []database.TemplateVersionVariable
 templateVersionWorkspaceTags  []database.TemplateVersionWorkspaceTag
 templates                     []database.TemplateTable
 templateUsageStats            []database.TemplateUsageStat
 workspaceAgents               []database.WorkspaceAgent
 workspaceAgentMetadata        []database.WorkspaceAgentMetadatum
 workspaceAgentLogs            []database.WorkspaceAgentLog
 workspaceAgentLogSources      []database.WorkspaceAgentLogSource
 workspaceAgentScripts         []database.WorkspaceAgentScript
 workspaceAgentPortShares      []database.WorkspaceAgentPortShare
 workspaceApps                 []database.WorkspaceApp
 workspaceAppStatsLastInsertID int64
 workspaceAppStats             []database.WorkspaceAppStat
 workspaceBuilds               []database.WorkspaceBuild
 workspaceBuildParameters      []database.WorkspaceBuildParameter
 workspaceResourceMetadata     []database.WorkspaceResourceMetadatum
 workspaceResources            []database.WorkspaceResource
 workspaces                    []database.Workspace
 workspaceProxies              []database.WorkspaceProxy
 customRoles                   []database.CustomRole
 provisionerJobTimings         []database.ProvisionerJobTiming
 runtimeConfig                 map[string]string
 auditLogs                       []database.AuditLog
 cryptoKeys                      []database.CryptoKey
 dbcryptKeys                     []database.DBCryptKey
 files                           []database.File
 externalAuthLinks               []database.ExternalAuthLink
 gitSSHKey                       []database.GitSSHKey
 groupMembers                    []database.GroupMemberTable
 groups                          []database.Group
 jfrogXRayScans                  []database.JfrogXrayScan
 licenses                        []database.License
 notificationMessages            []database.NotificationMessage
 notificationPreferences         []database.NotificationPreference
 notificationReportGeneratorLogs []database.NotificationReportGeneratorLog
 oauth2ProviderApps              []database.OAuth2ProviderApp
 oauth2ProviderAppSecrets        []database.OAuth2ProviderAppSecret
 oauth2ProviderAppCodes          []database.OAuth2ProviderAppCode
 oauth2ProviderAppTokens         []database.OAuth2ProviderAppToken
 parameterSchemas                []database.ParameterSchema
 provisionerDaemons              []database.ProvisionerDaemon
 provisionerJobLogs              []database.ProvisionerJobLog
 provisionerJobs                 []database.ProvisionerJob
 provisionerKeys                 []database.ProvisionerKey
 replicas                        []database.Replica
 templateVersions                []database.TemplateVersionTable
 templateVersionParameters       []database.TemplateVersionParameter
 templateVersionVariables        []database.TemplateVersionVariable
 templateVersionWorkspaceTags    []database.TemplateVersionWorkspaceTag
 templates                       []database.TemplateTable
 templateUsageStats              []database.TemplateUsageStat
 workspaceAgents                 []database.WorkspaceAgent
 workspaceAgentMetadata          []database.WorkspaceAgentMetadatum
 workspaceAgentLogs              []database.WorkspaceAgentLog
 workspaceAgentLogSources        []database.WorkspaceAgentLogSource
 workspaceAgentPortShares        []database.WorkspaceAgentPortShare
 workspaceAgentScripts           []database.WorkspaceAgentScript
 workspaceAgentStats             []database.WorkspaceAgentStat
 workspaceApps                   []database.WorkspaceApp
 workspaceAppStatsLastInsertID   int64
 workspaceAppStats               []database.WorkspaceAppStat
 workspaceBuilds                 []database.WorkspaceBuild
 workspaceBuildParameters        []database.WorkspaceBuildParameter
 workspaceResourceMetadata       []database.WorkspaceResourceMetadatum
 workspaceResources              []database.WorkspaceResource
 workspaces                      []database.Workspace
 workspaceProxies                []database.WorkspaceProxy
 customRoles                     []database.CustomRole
 provisionerJobTimings           []database.ProvisionerJobTiming
 runtimeConfig                   map[string]string
 // Locks is a map of lock names. Any keys within the map are currently
 // locked.
 locks                            map[int64]struct{}
 return gals, nil
 }

 func (q *FakeQuerier) GetFailedWorkspaceBuildsByTemplateID(ctx context.Context, arg database.GetFailedWorkspaceBuildsByTemplateIDParams) ([]database.GetFailedWorkspaceBuildsByTemplateIDRow, error) {
 err := validateDatabaseType(arg)
 if err != nil {
 return nil, err
 }

 q.mutex.RLock()
 defer q.mutex.RUnlock()

 workspaceBuildStats := []database.GetFailedWorkspaceBuildsByTemplateIDRow{}
 for _, wb := range q.workspaceBuilds {
 job, err := q.getProvisionerJobByIDNoLock(ctx, wb.JobID)
 if err != nil {
 return nil, xerrors.Errorf("get provisioner job by ID: %w", err)
 }

 if job.JobStatus != database.ProvisionerJobStatusFailed {
 continue
 }

 if !job.CompletedAt.Valid {
 continue
 }

 if wb.CreatedAt.Before(arg.Since) {
 continue
 }

 w, err := q.getWorkspaceByIDNoLock(ctx, wb.WorkspaceID)
 if err != nil {
 return nil, xerrors.Errorf("get workspace by ID: %w", err)
 }

 t, err := q.getTemplateByIDNoLock(ctx, w.TemplateID)
 if err != nil {
 return nil, xerrors.Errorf("get template by ID: %w", err)
 }

 if t.ID != arg.TemplateID {
 continue
 }

 workspaceOwner, err := q.getUserByIDNoLock(w.OwnerID)
 if err != nil {
 return nil, xerrors.Errorf("get user by ID: %w", err)
 }

 templateVersion, err := q.getTemplateVersionByIDNoLock(ctx, wb.TemplateVersionID)
 if err != nil {
 return nil, xerrors.Errorf("get template version by ID: %w", err)
 }

 workspaceBuildStats = append(workspaceBuildStats, database.GetFailedWorkspaceBuildsByTemplateIDRow{
 WorkspaceName:          w.Name,
 WorkspaceOwnerUsername: workspaceOwner.Username,
 TemplateVersionName:    templateVersion.Name,
 WorkspaceBuildNumber:   wb.BuildNumber,
 })
 }

 sort.Slice(workspaceBuildStats, func(i, j int) bool {
 if workspaceBuildStats[i].TemplateVersionName != workspaceBuildStats[j].TemplateVersionName {
 return workspaceBuildStats[i].TemplateVersionName < workspaceBuildStats[j].TemplateVersionName
 }
 return workspaceBuildStats[i].WorkspaceBuildNumber > workspaceBuildStats[j].WorkspaceBuildNumber
 })
 return workspaceBuildStats, nil
 }

 func (q *FakeQuerier) GetFileByHashAndCreator(_ context.Context, arg database.GetFileByHashAndCreatorParams) (database.File, error) {
 if err := validateDatabaseType(arg); err != nil {
 return database.File{}, err
 return out, nil
 }

 func (q *FakeQuerier) GetNotificationReportGeneratorLogByTemplate(_ context.Context, templateID uuid.UUID) (database.NotificationReportGeneratorLog, error) {
 err := validateDatabaseType(templateID)
 if err != nil {
 return database.NotificationReportGeneratorLog{}, err
 }

 q.mutex.RLock()
 defer q.mutex.RUnlock()

 for _, record := range q.notificationReportGeneratorLogs {
 if record.NotificationTemplateID == templateID {
 return record, nil
 }
 }
 return database.NotificationReportGeneratorLog{}, sql.ErrNoRows
 }

 func (*FakeQuerier) GetNotificationTemplateByID(_ context.Context, _ uuid.UUID) (database.NotificationTemplate, error) {
 // Not implementing this function because it relies on state in the database which is created with migrations.
 // We could consider using code-generation to align the database state and dbmem, but it's not worth it right now.
 return params, nil
 }

 func (q *FakeQuerier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
 q.mutex.RLock()
 defer q.mutex.RUnlock()

 templateStats := map[uuid.UUID]database.GetWorkspaceBuildStatsByTemplatesRow{}
 for _, wb := range q.workspaceBuilds {
 job, err := q.getProvisionerJobByIDNoLock(ctx, wb.JobID)
 if err != nil {
 return nil, xerrors.Errorf("get provisioner job by ID: %w", err)
 }

 if !job.CompletedAt.Valid {
 continue
 }

 if wb.CreatedAt.Before(since) {
 continue
 }

 w, err := q.getWorkspaceByIDNoLock(ctx, wb.WorkspaceID)
 if err != nil {
 return nil, xerrors.Errorf("get workspace by ID: %w", err)
 }

 if _, ok := templateStats[w.TemplateID]; !ok {
 t, err := q.getTemplateByIDNoLock(ctx, w.TemplateID)
 if err != nil {
 return nil, xerrors.Errorf("get template by ID: %w", err)
 }

 templateStats[w.TemplateID] = database.GetWorkspaceBuildStatsByTemplatesRow{
 TemplateID:             w.TemplateID,
 TemplateName:           t.Name,
 TemplateDisplayName:    t.DisplayName,
 TemplateOrganizationID: w.OrganizationID,
 }
 }

 s := templateStats[w.TemplateID]
 s.TotalBuilds++
 if job.JobStatus == database.ProvisionerJobStatusFailed {
 s.FailedBuilds++
 }
 templateStats[w.TemplateID] = s
 }

 rows := make([]database.GetWorkspaceBuildStatsByTemplatesRow, 0, len(templateStats))
 for _, ts := range templateStats {
 rows = append(rows, ts)
 }

 sort.Slice(rows, func(i, j int) bool {
 return rows[i].TemplateName < rows[j].TemplateName
 })
 return rows, nil
 }

 func (q *FakeQuerier) GetWorkspaceBuildsByWorkspaceID(_ context.Context,
 params database.GetWorkspaceBuildsByWorkspaceIDParams,
 ) ([]database.WorkspaceBuild, error) {
 return nil
 }

 func (q *FakeQuerier) UpsertNotificationReportGeneratorLog(_ context.Context, arg database.UpsertNotificationReportGeneratorLogParams) error {
 err := validateDatabaseType(arg)
 if err != nil {
 return err
 }

 q.mutex.Lock()
 defer q.mutex.Unlock()

 for i, record := range q.notificationReportGeneratorLogs {
 if arg.NotificationTemplateID == record.NotificationTemplateID {
 q.notificationReportGeneratorLogs[i].LastGeneratedAt = arg.LastGeneratedAt
 return nil
 }
 }

 q.notificationReportGeneratorLogs = append(q.notificationReportGeneratorLogs, database.NotificationReportGeneratorLog(arg))
 return nil
 }

 func (q *FakeQuerier) UpsertNotificationsSettings(_ context.Context, data string) error {
 q.mutex.Lock()
 defer q.mutex.Unlock()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -56,6 +56,7 @@ import (
		"cdr.dev/slog"
		"cdr.dev/slog/sloggers/sloghuman"
		"github.com/coder/coder/v2/coderd/entitlements"
		"github.com/coder/coder/v2/coderd/notifications/reports"
		"github.com/coder/coder/v2/coderd/runtimeconfig"
		"github.com/coder/pretty"
		"github.com/coder/quartz"
Expand DownExpand Up		@@ -1018,6 +1019,10 @@ func (r RootCmd) Server(newAPI func(context.Context, coderd.Options) (*coderd.

		// nolint:gocritic // TODO: create own role.
		notificationsManager.Run(dbauthz.AsSystemRestricted(ctx))

		// Run report generator to distribute periodic reports.
		notificationReportGenerator := reports.NewReportGenerator(ctx, logger, options.Database, options.NotificationsEnqueuer, quartz.NewReal())
		defer notificationReportGenerator.Close()
		}

		// Wrap the server in middleware that redirects to the access URL if
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1459,6 +1459,13 @@ func (q *querier) GetExternalAuthLinksByUserID(ctx context.Context, userID uuid.
		return fetchWithPostFilter(q.auth, policy.ActionReadPersonal, q.db.GetExternalAuthLinksByUserID)(ctx, userID)
		}

		func (q *querier) GetFailedWorkspaceBuildsByTemplateID(ctx context.Context, arg database.GetFailedWorkspaceBuildsByTemplateIDParams) ([]database.GetFailedWorkspaceBuildsByTemplateIDRow, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
		return nil, err
		}
		return q.db.GetFailedWorkspaceBuildsByTemplateID(ctx, arg)
		}

		func (q *querier) GetFileByHashAndCreator(ctx context.Context, arg database.GetFileByHashAndCreatorParams) (database.File, error) {
		file, err := q.db.GetFileByHashAndCreator(ctx, arg)
		if err != nil {
Expand DownExpand Up		@@ -1628,6 +1635,13 @@ func (q *querier) GetNotificationMessagesByStatus(ctx context.Context, arg datab
		return q.db.GetNotificationMessagesByStatus(ctx, arg)
		}

		func (q *querier) GetNotificationReportGeneratorLogByTemplate(ctx context.Context, arg uuid.UUID) (database.NotificationReportGeneratorLog, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
		return database.NotificationReportGeneratorLog{}, err
		}
		return q.db.GetNotificationReportGeneratorLogByTemplate(ctx, arg)
		}

		func (q *querier) GetNotificationTemplateByID(ctx context.Context, id uuid.UUID) (database.NotificationTemplate, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceNotificationTemplate); err != nil {
		return database.NotificationTemplate{}, err
Expand DownExpand Up		@@ -2510,6 +2524,13 @@ func (q *querier) GetWorkspaceBuildParameters(ctx context.Context, workspaceBuil
		return q.db.GetWorkspaceBuildParameters(ctx, workspaceBuildID)
		}

		func (q *querier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
		if err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceSystem); err != nil {
		return nil, err
		}
		return q.db.GetWorkspaceBuildStatsByTemplates(ctx, since)
		}

		func (q *querier) GetWorkspaceBuildsByWorkspaceID(ctx context.Context, arg database.GetWorkspaceBuildsByWorkspaceIDParams) ([]database.WorkspaceBuild, error) {
		if _, err := q.GetWorkspaceByID(ctx, arg.WorkspaceID); err != nil {
		return nil, err
Expand DownExpand Up		@@ -3966,6 +3987,13 @@ func (q *querier) UpsertLogoURL(ctx context.Context, value string) error {
		return q.db.UpsertLogoURL(ctx, value)
		}

		func (q *querier) UpsertNotificationReportGeneratorLog(ctx context.Context, arg database.UpsertNotificationReportGeneratorLogParams) error {
		if err := q.authorizeContext(ctx, policy.ActionCreate, rbac.ResourceSystem); err != nil {
		return err
		}
		return q.db.UpsertNotificationReportGeneratorLog(ctx, arg)
		}

		func (q *querier) UpsertNotificationsSettings(ctx context.Context, value string) error {
		if err := q.authorizeContext(ctx, policy.ActionUpdate, rbac.ResourceDeploymentConfig); err != nil {
		return err
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2819,6 +2819,28 @@ func (s *MethodTestSuite) TestSystemFunctions() {
		Value: "value",
		}).Asserts(rbac.ResourceSystem, policy.ActionCreate)
		}))
		s.Run("GetFailedWorkspaceBuildsByTemplateID", s.Subtest(func(db database.Store, check *expects) {
		check.Args(database.GetFailedWorkspaceBuildsByTemplateIDParams{
		TemplateID: uuid.New(),
		Since: dbtime.Now(),
		}).Asserts(rbac.ResourceSystem, policy.ActionRead)
		}))
		s.Run("GetNotificationReportGeneratorLogByTemplate", s.Subtest(func(db database.Store, check *expects) {
		_ = db.UpsertNotificationReportGeneratorLog(context.Background(), database.UpsertNotificationReportGeneratorLogParams{
		NotificationTemplateID: notifications.TemplateWorkspaceBuildsFailedReport,
		LastGeneratedAt: dbtime.Now(),
		})
		check.Args(notifications.TemplateWorkspaceBuildsFailedReport).Asserts(rbac.ResourceSystem, policy.ActionRead)
		}))
		s.Run("GetWorkspaceBuildStatsByTemplates", s.Subtest(func(db database.Store, check *expects) {
		check.Args(dbtime.Now()).Asserts(rbac.ResourceSystem, policy.ActionRead)
		}))
		s.Run("UpsertNotificationReportGeneratorLog", s.Subtest(func(db database.Store, check *expects) {
		check.Args(database.UpsertNotificationReportGeneratorLogParams{
		NotificationTemplateID: uuid.New(),
		LastGeneratedAt: dbtime.Now(),
		}).Asserts(rbac.ResourceSystem, policy.ActionCreate)
		}))
		}

		func (s *MethodTestSuite) TestNotifications() {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -187,53 +187,54 @@ type data struct {
		userLinks []database.UserLink

		// New tables
		workspaceAgentStats []database.WorkspaceAgentStat
		auditLogs []database.AuditLog
		cryptoKeys []database.CryptoKey
		dbcryptKeys []database.DBCryptKey
		files []database.File
		externalAuthLinks []database.ExternalAuthLink
		gitSSHKey []database.GitSSHKey
		groupMembers []database.GroupMemberTable
		groups []database.Group
		jfrogXRayScans []database.JfrogXrayScan
		licenses []database.License
		notificationMessages []database.NotificationMessage
		notificationPreferences []database.NotificationPreference
		oauth2ProviderApps []database.OAuth2ProviderApp
		oauth2ProviderAppSecrets []database.OAuth2ProviderAppSecret
		oauth2ProviderAppCodes []database.OAuth2ProviderAppCode
		oauth2ProviderAppTokens []database.OAuth2ProviderAppToken
		parameterSchemas []database.ParameterSchema
		provisionerDaemons []database.ProvisionerDaemon
		provisionerJobLogs []database.ProvisionerJobLog
		provisionerJobs []database.ProvisionerJob
		provisionerKeys []database.ProvisionerKey
		replicas []database.Replica
		templateVersions []database.TemplateVersionTable
		templateVersionParameters []database.TemplateVersionParameter
		templateVersionVariables []database.TemplateVersionVariable
		templateVersionWorkspaceTags []database.TemplateVersionWorkspaceTag
		templates []database.TemplateTable
		templateUsageStats []database.TemplateUsageStat
		workspaceAgents []database.WorkspaceAgent
		workspaceAgentMetadata []database.WorkspaceAgentMetadatum
		workspaceAgentLogs []database.WorkspaceAgentLog
		workspaceAgentLogSources []database.WorkspaceAgentLogSource
		workspaceAgentScripts []database.WorkspaceAgentScript
		workspaceAgentPortShares []database.WorkspaceAgentPortShare
		workspaceApps []database.WorkspaceApp
		workspaceAppStatsLastInsertID int64
		workspaceAppStats []database.WorkspaceAppStat
		workspaceBuilds []database.WorkspaceBuild
		workspaceBuildParameters []database.WorkspaceBuildParameter
		workspaceResourceMetadata []database.WorkspaceResourceMetadatum
		workspaceResources []database.WorkspaceResource
		workspaces []database.Workspace
		workspaceProxies []database.WorkspaceProxy
		customRoles []database.CustomRole
		provisionerJobTimings []database.ProvisionerJobTiming
		runtimeConfig map[string]string
		auditLogs []database.AuditLog
		cryptoKeys []database.CryptoKey
		dbcryptKeys []database.DBCryptKey
		files []database.File
		externalAuthLinks []database.ExternalAuthLink
		gitSSHKey []database.GitSSHKey
		groupMembers []database.GroupMemberTable
		groups []database.Group
		jfrogXRayScans []database.JfrogXrayScan
		licenses []database.License
		notificationMessages []database.NotificationMessage
		notificationPreferences []database.NotificationPreference
		notificationReportGeneratorLogs []database.NotificationReportGeneratorLog
		oauth2ProviderApps []database.OAuth2ProviderApp
		oauth2ProviderAppSecrets []database.OAuth2ProviderAppSecret
		oauth2ProviderAppCodes []database.OAuth2ProviderAppCode
		oauth2ProviderAppTokens []database.OAuth2ProviderAppToken
		parameterSchemas []database.ParameterSchema
		provisionerDaemons []database.ProvisionerDaemon
		provisionerJobLogs []database.ProvisionerJobLog
		provisionerJobs []database.ProvisionerJob
		provisionerKeys []database.ProvisionerKey
		replicas []database.Replica
		templateVersions []database.TemplateVersionTable
		templateVersionParameters []database.TemplateVersionParameter
		templateVersionVariables []database.TemplateVersionVariable
		templateVersionWorkspaceTags []database.TemplateVersionWorkspaceTag
		templates []database.TemplateTable
		templateUsageStats []database.TemplateUsageStat
		workspaceAgents []database.WorkspaceAgent
		workspaceAgentMetadata []database.WorkspaceAgentMetadatum
		workspaceAgentLogs []database.WorkspaceAgentLog
		workspaceAgentLogSources []database.WorkspaceAgentLogSource
		workspaceAgentPortShares []database.WorkspaceAgentPortShare
		workspaceAgentScripts []database.WorkspaceAgentScript
		workspaceAgentStats []database.WorkspaceAgentStat
		workspaceApps []database.WorkspaceApp
		workspaceAppStatsLastInsertID int64
		workspaceAppStats []database.WorkspaceAppStat
		workspaceBuilds []database.WorkspaceBuild
		workspaceBuildParameters []database.WorkspaceBuildParameter
		workspaceResourceMetadata []database.WorkspaceResourceMetadatum
		workspaceResources []database.WorkspaceResource
		workspaces []database.Workspace
		workspaceProxies []database.WorkspaceProxy
		customRoles []database.CustomRole
		provisionerJobTimings []database.ProvisionerJobTiming
		runtimeConfig map[string]string
		// Locks is a map of lock names. Any keys within the map are currently
		// locked.
		locks map[int64]struct{}
Expand DownExpand Up		@@ -2621,6 +2622,75 @@ func (q *FakeQuerier) GetExternalAuthLinksByUserID(_ context.Context, userID uui
		return gals, nil
		}

		func (q *FakeQuerier) GetFailedWorkspaceBuildsByTemplateID(ctx context.Context, arg database.GetFailedWorkspaceBuildsByTemplateIDParams) ([]database.GetFailedWorkspaceBuildsByTemplateIDRow, error) {
		err := validateDatabaseType(arg)
		if err != nil {
		return nil, err
		}

		q.mutex.RLock()
		defer q.mutex.RUnlock()

		workspaceBuildStats := []database.GetFailedWorkspaceBuildsByTemplateIDRow{}
		for _, wb := range q.workspaceBuilds {
		job, err := q.getProvisionerJobByIDNoLock(ctx, wb.JobID)
		if err != nil {
		return nil, xerrors.Errorf("get provisioner job by ID: %w", err)
		}

		if job.JobStatus != database.ProvisionerJobStatusFailed {
		continue
		}

		if !job.CompletedAt.Valid {
		continue
		}

		if wb.CreatedAt.Before(arg.Since) {
		continue
		}

		w, err := q.getWorkspaceByIDNoLock(ctx, wb.WorkspaceID)
		if err != nil {
		return nil, xerrors.Errorf("get workspace by ID: %w", err)
		}

		t, err := q.getTemplateByIDNoLock(ctx, w.TemplateID)
		if err != nil {
		return nil, xerrors.Errorf("get template by ID: %w", err)
		}

		if t.ID != arg.TemplateID {
		continue
		}

		workspaceOwner, err := q.getUserByIDNoLock(w.OwnerID)
		if err != nil {
		return nil, xerrors.Errorf("get user by ID: %w", err)
		}

		templateVersion, err := q.getTemplateVersionByIDNoLock(ctx, wb.TemplateVersionID)
		if err != nil {
		return nil, xerrors.Errorf("get template version by ID: %w", err)
		}

		workspaceBuildStats = append(workspaceBuildStats, database.GetFailedWorkspaceBuildsByTemplateIDRow{
		WorkspaceName: w.Name,
		WorkspaceOwnerUsername: workspaceOwner.Username,
		TemplateVersionName: templateVersion.Name,
		WorkspaceBuildNumber: wb.BuildNumber,
		})
		}

		sort.Slice(workspaceBuildStats, func(i, j int) bool {
		if workspaceBuildStats[i].TemplateVersionName != workspaceBuildStats[j].TemplateVersionName {
		return workspaceBuildStats[i].TemplateVersionName < workspaceBuildStats[j].TemplateVersionName
		}
		return workspaceBuildStats[i].WorkspaceBuildNumber > workspaceBuildStats[j].WorkspaceBuildNumber
		})
		return workspaceBuildStats, nil
		}

		func (q *FakeQuerier) GetFileByHashAndCreator(_ context.Context, arg database.GetFileByHashAndCreatorParams) (database.File, error) {
		if err := validateDatabaseType(arg); err != nil {
		return database.File{}, err
Expand DownExpand Up		@@ -3044,6 +3114,23 @@ func (q *FakeQuerier) GetNotificationMessagesByStatus(_ context.Context, arg dat
		return out, nil
		}

		func (q *FakeQuerier) GetNotificationReportGeneratorLogByTemplate(_ context.Context, templateID uuid.UUID) (database.NotificationReportGeneratorLog, error) {
		err := validateDatabaseType(templateID)
		if err != nil {
		return database.NotificationReportGeneratorLog{}, err
		}

		q.mutex.RLock()
		defer q.mutex.RUnlock()

		for _, record := range q.notificationReportGeneratorLogs {
		if record.NotificationTemplateID == templateID {
		return record, nil
		}
		}
		return database.NotificationReportGeneratorLog{}, sql.ErrNoRows
		}

		func (*FakeQuerier) GetNotificationTemplateByID(_ context.Context, _ uuid.UUID) (database.NotificationTemplate, error) {
		// Not implementing this function because it relies on state in the database which is created with migrations.
		// We could consider using code-generation to align the database state and dbmem, but it's not worth it right now.
Expand DownExpand Up		@@ -5964,6 +6051,63 @@ func (q *FakeQuerier) GetWorkspaceBuildParameters(_ context.Context, workspaceBu
		return params, nil
		}

		func (q *FakeQuerier) GetWorkspaceBuildStatsByTemplates(ctx context.Context, since time.Time) ([]database.GetWorkspaceBuildStatsByTemplatesRow, error) {
		q.mutex.RLock()
		defer q.mutex.RUnlock()

		templateStats := map[uuid.UUID]database.GetWorkspaceBuildStatsByTemplatesRow{}
		for _, wb := range q.workspaceBuilds {
		job, err := q.getProvisionerJobByIDNoLock(ctx, wb.JobID)
		if err != nil {
		return nil, xerrors.Errorf("get provisioner job by ID: %w", err)
		}

		if !job.CompletedAt.Valid {
		continue
		}

		if wb.CreatedAt.Before(since) {
		continue
		}

		w, err := q.getWorkspaceByIDNoLock(ctx, wb.WorkspaceID)
		if err != nil {
		return nil, xerrors.Errorf("get workspace by ID: %w", err)
		}

		if _, ok := templateStats[w.TemplateID]; !ok {
		t, err := q.getTemplateByIDNoLock(ctx, w.TemplateID)
		if err != nil {
		return nil, xerrors.Errorf("get template by ID: %w", err)
		}

		templateStats[w.TemplateID] = database.GetWorkspaceBuildStatsByTemplatesRow{
		TemplateID: w.TemplateID,
		TemplateName: t.Name,
		TemplateDisplayName: t.DisplayName,
		TemplateOrganizationID: w.OrganizationID,
		}
		}

		s := templateStats[w.TemplateID]
		s.TotalBuilds++
		if job.JobStatus == database.ProvisionerJobStatusFailed {
		s.FailedBuilds++
		}
		templateStats[w.TemplateID] = s
		}

		rows := make([]database.GetWorkspaceBuildStatsByTemplatesRow, 0, len(templateStats))
		for _, ts := range templateStats {
		rows = append(rows, ts)
		}

		sort.Slice(rows, func(i, j int) bool {
		return rows[i].TemplateName < rows[j].TemplateName
		})
		return rows, nil
		}

		func (q *FakeQuerier) GetWorkspaceBuildsByWorkspaceID(_ context.Context,
		params database.GetWorkspaceBuildsByWorkspaceIDParams,
		) ([]database.WorkspaceBuild, error) {
Expand DownExpand Up		@@ -9440,6 +9584,26 @@ func (q *FakeQuerier) UpsertLogoURL(_ context.Context, data string) error {
		return nil
		}

		func (q *FakeQuerier) UpsertNotificationReportGeneratorLog(_ context.Context, arg database.UpsertNotificationReportGeneratorLogParams) error {
		err := validateDatabaseType(arg)
		if err != nil {
		return err
		}

		q.mutex.Lock()
		defer q.mutex.Unlock()

		for i, record := range q.notificationReportGeneratorLogs {
		if arg.NotificationTemplateID == record.NotificationTemplateID {
		q.notificationReportGeneratorLogs[i].LastGeneratedAt = arg.LastGeneratedAt
		return nil
		}
		}

		q.notificationReportGeneratorLogs = append(q.notificationReportGeneratorLogs, database.NotificationReportGeneratorLog(arg))
		return nil
		}

		func (q *FakeQuerier) UpsertNotificationsSettings(_ context.Context, data string) error {
		q.mutex.Lock()
		defer q.mutex.Unlock()
Expand Down