Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add 'hidden' option to 'coder_app' to hide app from UI#14570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 10 commits intomainfromdm-allow-hide-coder_app-button
Sep 9, 2024

Conversation

@DanielleMaywood
Copy link
Contributor

Resolves#13265

Adds support for thehidden field added to a workspace app. This field allows hiding an app from the user interface.

Screen.Recording.2024-09-05.at.10.08.02.mp4

@DanielleMaywoodDanielleMaywood changed the titleWIP: feat: add 'hidden' option to 'coder_app' to hide app from UIfeat: add 'hidden' option to 'coder_app' to hide app from UISep 5, 2024
@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewSeptember 5, 2024 12:08
@DanielleMaywoodDanielleMaywood marked this pull request as draftSeptember 5, 2024 12:09
@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewSeptember 5, 2024 15:40
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That was a very quick PR, great work! I raised a concern about potential conflicts in the agent properties' values. If it's too difficult or impractical to safely introduce validation, I would recommend leaving it as is.

@DanielleMaywoodDanielleMaywoodforce-pushed thedm-allow-hide-coder_app-button branch fromab0e0ca toed9791eCompareSeptember 6, 2024 09:58
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggest adding a story for this but apart from that LGTM 👍

@mtojek
Copy link
Member

Folks, are we going to release the provider changes first, and then updatego.mod here?

@johnstcn
Copy link
Member

Folks, are we going to release the provider changes first, and then updatego.mod here?

☝️ Forgot about this!

@DanielleMaywoodDanielleMaywoodforce-pushed thedm-allow-hide-coder_app-button branch frome04d1c1 toc8b9425CompareSeptember 9, 2024 13:01
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@DanielleMaywoodDanielleMaywood merged commit25f1ddb intomainSep 9, 2024
@DanielleMaywoodDanielleMaywood deleted the dm-allow-hide-coder_app-button branchSeptember 9, 2024 13:39
Emyrk pushed a commit that referenced this pull requestSep 9, 2024
Add 'hidden' property to 'coder_app' resource to allow hiding apps from the UI.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@mtojekmtojekmtojek approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optionally hidecoder_app button in dashboard

4 participants

@DanielleMaywood@mtojek@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp