Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: make cli respect deployment --docs-url#14568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 5, 2024
edited
Loading

With#14548, it's a lot more likely for a user to see a documentation link when using the CLI.

Assuming admins of airgapped Coder deployments aren't giving regular users permission to view the deployment config, we'll need to make the docs URL available on the more permissive/appearance endpoint.

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 5, 2024 06:38
@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch from3ac949f to75cd7beCompareSeptember 10, 2024 05:38
@ethanndickson
Copy link
MemberAuthor

(No changes in previous push, just rebase)

@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch from75cd7be to1c80204CompareSeptember 10, 2024 05:41
@ethanndickson
Copy link
MemberAuthor

If we're going to fetch the deployment config on startup, I think making it optional middlware, instead of making it part of say,initClient is better - no CLI command has needed anything from the deployment config up until now.

@ethanndickson
Copy link
MemberAuthor

I only just noticed these tests failed, because viewing deployment config is restricted - I still think just having adocsURL function that fetches and otherwise defaults to the main docs is the best way to do this.

@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch from1c80204 to87ea95cCompareSeptember 12, 2024 13:41
@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedSep 12, 2024
edited
Loading

Nah, I had to rethink it all - most admins are probably not giving regular users permissions to view the deployment config, so it needs to be included on/appearance, enterprise only, but presumably they're the only ones using offline docs. Basically a new PR altogether, so ignore the force push diff :D

I think I've missed a few doc links, so I'll get to those next

@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch 2 times, most recently from24a9a36 to4c276e6CompareSeptember 13, 2024 06:33
@ethanndickson
Copy link
MemberAuthor

This approach is definitely better, but since opening this PR we've added a docs link to a help command. We can't plumb the fetched appearance config there (nor would we want to do a fetch before a help command), so I'm not totally sure what to do about that. It would be nice if we could just an additional field to a local config, but the cli storessession andurl as whole files, and it feels a bit ridiculous to add a new file just for the docs url.

@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch 2 times, most recently fromc9e34ea to5bfb3adCompareSeptember 18, 2024 08:47
@ethanndicksonethanndicksonforce-pushed the09-05-fix_make_cli_respect_deployment_--docs-url branch from5bfb3ad to57a7f5cCompareSeptember 18, 2024 11:32
@ethanndicksonethanndickson merged commit37885e2 intomainSep 18, 2024
29 of 31 checks passed
@ethanndicksonethanndickson deleted the 09-05-fix_make_cli_respect_deployment_--docs-url branchSeptember 18, 2024 11:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 18, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp