- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: make cli respect deployment --docs-url#14568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix: make cli respect deployment --docs-url#14568
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
Uh oh!
There was an error while loading.Please reload this page.
3ac949f to75cd7beCompare(No changes in previous push, just rebase) |
75cd7be to1c80204CompareIf we're going to fetch the deployment config on startup, I think making it optional middlware, instead of making it part of say, |
I only just noticed these tests failed, because viewing deployment config is restricted - I still think just having a |
Uh oh!
There was an error while loading.Please reload this page.
1c80204 to87ea95cCompareethanndickson commentedSep 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Nah, I had to rethink it all - most admins are probably not giving regular users permissions to view the deployment config, so it needs to be included on I think I've missed a few doc links, so I'll get to those next |
24a9a36 to4c276e6CompareThis approach is definitely better, but since opening this PR we've added a docs link to a help command. We can't plumb the fetched appearance config there (nor would we want to do a fetch before a help command), so I'm not totally sure what to do about that. It would be nice if we could just an additional field to a local config, but the cli stores |
c9e34ea to5bfb3adCompare5bfb3ad to57a7f5cCompare
Uh oh!
There was an error while loading.Please reload this page.
With#14548, it's a lot more likely for a user to see a documentation link when using the CLI.
Assuming admins of airgapped Coder deployments aren't giving regular users permission to view the deployment config, we'll need to make the docs URL available on the more permissive
/appearanceendpoint.