Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(agent/agentssh): use tcp for X11 forwarding#14560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 3 commits intomainfrommafredri/x11-forwarding-ports
Sep 4, 2024

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedSep 4, 2024•
edited
Loading

This PR changes X11 forwarding from socket-based to TCP based. This matches OpenSSH behavior where theclient forwards from/tmp/.X11-unix/X* and the server listens onlocalhost:6000(+).

Since we can now have multiple SSH connections that each handle their individual X11 forwarding, we can end up adding more non-duplicate entries into~/.Xauthority as well. Ideally we would clean our entries up when the connection closes, but that's more of a nice-to-have and not part of this PR.

Note that X11 forwarding is still only supported by OpenSSH clients (coder config-ssh), this PR did not add X11 forwarding support tocoder ssh.

Fixes#14198

@mafredrimafredriforce-pushed themafredri/x11-forwarding-ports branch 3 times, most recently from9d3f404 to8fdf92fCompareSeptember 4, 2024 13:35
@mafredrimafredriforce-pushed themafredri/x11-forwarding-ports branch from8fdf92f tof6f2964CompareSeptember 4, 2024 14:29
@mafredrimafredri marked this pull request as ready for reviewSeptember 4, 2024 14:32
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nothing else blocking on my end!

@mafredrimafredri merged commit8f07d33 intomainSep 4, 2024
26 checks passed
@mafredrimafredri deleted the mafredri/x11-forwarding-ports branchSeptember 4, 2024 17:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

X11 forwarding should use network instead of unix socket and support being forwarded multiple times
2 participants
@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp