Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(cli): validate various names locally#14551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedSep 4, 2024•
edited
Loading

Closes#14544.
Closes#10244.

As mentioned incoder/terraform-provider-coderd#85,coderd doesn't currently provide an error reason when a field in a requestfails to validate. This means the CLI provides an arguably useless error message when a supplied name is invalid.

Even ifcoderd supplied an error reason when a field failed to validate, the problem in#14544 would still result in a not great UX, only showing the error after a plan (which could reasonably take several minutes for some Terraform providers).

I think it's okay to follow the Web UI here, and validate locally first, especially since bothcoderd and the CLI will call the same validator implementation incodersdk.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedSep 4, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewSeptember 4, 2024 07:12
@ethanndicksonethanndickson changed the base branch from09-04-feat_codersdk_export_name_validators tographite-base/14551September 4, 2024 08:17
@ethanndicksonethanndicksonforce-pushed the09-04-chore_cli_validate_various_names_locally branch from4fd4b55 to5e0c568CompareSeptember 4, 2024 08:18
@graphite-appgraphite-appbot changed the base branch fromgraphite-base/14551 tomainSeptember 4, 2024 08:18
@ethanndicksonethanndicksonforce-pushed the09-04-chore_cli_validate_various_names_locally branch from5e0c568 to09de864CompareSeptember 4, 2024 08:18
@ethanndicksonethanndicksonforce-pushed the09-04-chore_cli_validate_various_names_locally branch from09de864 to4bc6cfdCompareSeptember 4, 2024 08:21
@ethanndicksonethanndicksonenabled auto-merge (squash)September 4, 2024 08:21
@ethanndicksonethanndickson merged commit8f85464 intomainSep 4, 2024
@ethanndicksonethanndickson deleted the 09-04-chore_cli_validate_various_names_locally branchSeptember 4, 2024 08:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI:coder create does not check/sanitize workspace name before creating ImproveValidation failed error message for template names with underscores

3 participants

@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp