Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: create idp sync page skeleton#14543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 14 commits intomainfromjaaydenh/idp-sync-skeleton
Sep 6, 2024
Merged

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedSep 3, 2024
edited
Loading

resolves#14423

This is meant to be a first pass at the IdP Sync page while waiting for the backend work to be completed. Additional, polish and refinement will be handled in#14424

  • Buttons to link to docs page
  • Table for group sync mappings
  • Table for role sync mappings
  • Export policy button
  • Fields for group, role, group auto create and group regex filter
  • ? icon with help tooltip
  • Status indicator for group/role sync fields only when disabled (missing from backend response)
  • Storybook stories
  • Setup mock data

@jaaydenhjaaydenh self-assigned thisSep 3, 2024
@jaaydenhjaaydenh marked this pull request as ready for reviewSeptember 3, 2024 20:39
Copy link
Contributor

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Noticed a couple of things, but I'm not going to block on them
I know there's going to be more polish, so I'll leave it to you to decide when these should be addressed

skip_issuer_checks:true,
};

exportconstIdpSyncPage:FC=()=>{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just calling this out because I don't see anything about this in the commented-out code: do we want to do a redirect if the user navigates to this page iforganization.permissions.editMembers is false?

I know we're using that property to define whether we show the page link in the side navbar, but is there anything stopping someone from navigating to the page directly?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Parkreiner I haven't addressed permissions yet because a permission hasn't been defined for this page. Btw, how do other pages handle this case when the user doesn't have the permissions?

organization_mapping:{},
organization_assign_default:true,
group_auto_create:false,
group_regex_filter:"^Coder-.*$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I know this is a mock value, but could I get more context on where this regex is used? Is it strictly server-controlled?

Wondering because the.*$ at the end literally does nothing in this case except make the regex run slower

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

All the data is readonly and for now I just took the value from Steven. Im still learning myself how this feature works.

Comment on lines +25 to +27
exporttypeIdpSyncPageViewProps={
oidcConfig:OIDCConfig|undefined;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since this is the only prop right now, do we want to couple the UI so tightly to the shape of the API response? My gut feeling is "no", but I don't know enough about the domain to know if this is going to matter much, especially if we have the mock config defined

Nit: I feel like we could also wrap this type in theReadonly utility type

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I actually don't know yet what the API response will look like. All I know is that it will have some similarity to what exists in OIDCConfig. So right now this is just meant to be an approximation to mock some data with the assumption that it will change.

Copy link
Contributor

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since@aslilac and@Parkreiner are reviewing this as well I just did some QA and it looks ok considering the scope of this PR 👍

@jaaydenhjaaydenhforce-pushed thejaaydenh/idp-sync-skeleton branch fromf6f18ce to1523025CompareSeptember 5, 2024 23:08
@jaaydenhjaaydenh merged commit6b9e1d4 intomainSep 6, 2024
@jaaydenhjaaydenh deleted the jaaydenh/idp-sync-skeleton branchSeptember 6, 2024 19:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

+2 more reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma left review comments

@ParkreinerParkreinerParkreiner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI: Create skeleton page for IDP sync

5 participants

@jaaydenh@aslilac@BrunoQuaresma@Parkreiner

[8]ページ先頭

©2009-2025 Movatter.jp