Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: CreateWorkspaceForm name validation#1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
greyscaled merged 2 commits intomainfromvapurrmaid/gh-1421/username-validation
May 16, 2022

Conversation

greyscaled
Copy link
Contributor

@greyscaledgreyscaled commentedMay 14, 2022•
edited
Loading

Resolves:#1421

  • adjustgetFormHelpers to allowhelperText
  • refactorCreateWorkspaceForm to haveLanguage, removeFormTextField and meet conventions
  • add missing validations to Workspace name
  • make Workspace name auto-focused

validation

By passing in helperText, we will not accidentally overwrite it.
@greyscaledgreyscaled self-assigned thisMay 14, 2022
@greyscaledgreyscaled requested a review froma team as acode ownerMay 14, 2022 15:42
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
Copy link
Contributor

@presleyppresleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice! I don't know how (if?) we're going to extend the validation from the name field to the arbitrary fields but it's nice to get things in order in advance of that at least.

greyscaled reacted with thumbs up emoji
@greyscaledgreyscaled merged commit9d4182b intomainMay 16, 2022
@greyscaledgreyscaled deleted the vapurrmaid/gh-1421/username-validation branchMay 16, 2022 19:30
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* refactor: allow helperText in getFormHelpersBy passing in helperText, we will not accidentally overwrite it.* fix: CreateWorkspaceForm name validationResolves:#1421
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@presleyppresleyppresleyp approved these changes

@Kira-PilotKira-PilotKira-Pilot approved these changes

Assignees

@greyscaledgreyscaled

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

UI: Entering an invalid a Workspace Name in Create returns no error
4 participants
@greyscaled@presleyp@Kira-Pilot@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp