Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add provisioners view to organization settings#14501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 11 commits intomainfromorg-provisioners-page
Sep 4, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedAug 30, 2024
edited
Loading

Closes#14436

  • View details about each provisioner such as scope and version (PSK tags and other details will be handled in a separate ticket)
  • View details about each provisioner such as name, tags, created at, last used
  • View provisioner warnings
  • CTA to create a new provisioner (links to docs)
  • Add storybooks

Warnings aren't implemented yet on the backend, but the rest of this should be ready to go! I can handle those as part of another PR to avoid blocking this work if they're not done soon.

@aslilacaslilac changed the titlefeat: view provisioners from organization settingsfeat: add provisioners view to organization settingsSep 3, 2024
@aslilacaslilac marked this pull request as ready for reviewSeptember 3, 2024 22:09
@jaaydenh
Copy link
Contributor

Both organization provisioners and groups are enterprise features, however groups displays the enterprise banner but for provisioners an error message is displayed. It would make sense for both of these cases to have the same behavior and show thePaywall component.

Screenshot 2024-09-04 at 2 42 02 PM

@jaaydenh
Copy link
Contributor

Asking this mainly because I want to update the docs and want to fully understand the terminology. How did you decide that Provisioner.tsx and ProvisionerTag.tsx are modules and something like OrganizationAutocomplete or Paywall is a component? Should OrganizationAutocomplete or Paywall actually have been modules?

@aslilac
Copy link
MemberAuthor

aslilac commentedSep 4, 2024
edited
Loading

I thinkOrganizationAutocomplete andPaywall should actually both be in modules/ as well. I think "components" are atomic, simple, and not tied to our specific product; they should be useful in other settings as well.

@jaaydenh
Copy link
Contributor

Nice, I like the distinction that Components could be technically be used in any project and still make sense.

>
<PageHeaderTitle>Provisioners</PageHeaderTitle>
</PageHeader>
<Stack spacing={4.5}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I feel the way this is definedgap: spacing * 8, sort of constrains the UI to consistent spacing in multiples of 8 if we only use whole numbers for spacing. I would argue that for consistency we should keep whole numbers or rethink the spacing * 8 definition.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should rethink the* 8 definition. If you do a search forspacing={ you'll see that the codebase is already covered in.5 spacings. 😅 This is just the spacing that the health page already uses, and I think it looks right.

…PageView.tsxCo-authored-by: Jaayden Halko <jaayden.halko@gmail.com>
@jaaydenhjaaydenh self-requested a reviewSeptember 4, 2024 20:10
Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@aslilacaslilac merged commit84922e2 intomainSep 4, 2024
27 checks passed
@aslilacaslilac deleted the org-provisioners-page branchSeptember 4, 2024 22:21
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

@ParkreinerParkreinerAwaiting requested review from Parkreiner

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Organization Provisioners Page
2 participants
@aslilac@jaaydenh

[8]ページ先頭

©2009-2025 Movatter.jp