Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: allow posting licenses that will be valid in future#14491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/14476-post-license
Sep 3, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedAug 30, 2024•
edited
Loading

relates to#14476

Fixes our license POST handler such that you can post a license that isn't yet valid, but will be in the future. Previously we rejected such requests; c.f. the linked issue for context.

@spikecurtisGraphite App
Copy link
ContributorAuthor

spikecurtis commentedAug 30, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@spikecurtis and the rest of your teammates onGraphiteGraphite

@spikecurtisspikecurtis marked this pull request as ready for reviewAugust 30, 2024 08:00
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I took a look at the JWT flow to make sure that error does not short circuit anything.

Nifty approach to returning multiple errors 👍

@spikecurtisspikecurtis merged commit5bd5801 intomainSep 3, 2024
32 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/14476-post-license branchSeptember 3, 2024 05:09
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 3, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@spikecurtis@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp