Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: only show license expiry warning for deployment admins#14488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 30, 2024•
edited
Loading

Fixes#13939.

The expiry notice is currently only shown to users with at least one role.
Since it's reasonable to have a role but not be considered a deployment admin, we'll only show the warning if the user has permission to read the deployment config.

Stacked as CI would not otherwise pass until#14489 is merged.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 30, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 30, 2024 03:53
@ethanndicksonethanndicksonforce-pushed the08-30-chore_only_show_license_expiry_warning_for_deployment_admins branch from50b9836 to38a1f9aCompareAugust 30, 2024 05:32
@ethanndicksonethanndickson changed the base branch frommain to08-30-fix_delete_workspace_agent_stats_after_180_daysAugust 30, 2024 05:32
@ethanndicksonethanndickson changed the base branch from08-30-fix_delete_workspace_agent_stats_after_180_days tographite-base/14488August 30, 2024 08:30
@ethanndicksonethanndicksonforce-pushed the08-30-chore_only_show_license_expiry_warning_for_deployment_admins branch from38a1f9a tob6f8edfCompareAugust 30, 2024 08:30
@ethanndicksonethanndickson changed the base branch fromgraphite-base/14488 tomainAugust 30, 2024 08:30
@ethanndicksonethanndicksonforce-pushed the08-30-chore_only_show_license_expiry_warning_for_deployment_admins branch fromb6f8edf to5545c0dCompareAugust 30, 2024 08:30
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Reasonable to me, much better than role checking 👍

@ethanndicksonethanndickson merged commite5d4f35 intomainSep 2, 2024
28 checks passed
@ethanndicksonethanndickson deleted the 08-30-chore_only_show_license_expiry_warning_for_deployment_admins branchSeptember 2, 2024 07:54
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsSep 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cli: license expiry warning shows for end-users, customers
2 participants
@ethanndickson@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp