NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

fix: make non-existent asset paths return a 404#14472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 2 commits intomainfromasher/asset-404

Aug 29, 2024

Merged

fix: make non-existent asset paths return a 404#14472

code-asher merged 2 commits intomainfromasher/asset-404

Aug 29, 2024

Conversation

Copy link

Member

code-asher commentedAug 28, 2024•
edited
Loading

Before, if a file was not found we would serve the app. I do not think we were relying on falling back to the app for/assets so should be safe to just return a 404 instead.

Fixes#14409

github-actionsbot assignedcode-asher

Aug 28, 2024

code-asher force-pushed theasher/asset-404 branch fromc638800 to6e20242Compare

August 28, 2024 18:08

fix: make non-existent asset paths return a 404

e6cc650

Before, if a file was not found we would serve the app.

code-asher force-pushed theasher/asset-404 branch from6e20242 toe6cc650Compare

August 28, 2024 18:08

code-asher marked this pull request as ready for review

August 28, 2024 18:14

code-asher requested a review fromBrunoQuaresma

August 28, 2024 18:14

Copy link

MemberAuthor

code-asher commentedAug 28, 2024•
edited
Loading

@BrunoQuaresma we are not relying on/assets or/assets/* serving the app anywhere, right? Just want to make sure I am not breaking something in the frontend by handling missing assets in the backend