- Notifications
You must be signed in to change notification settings - Fork1k
feat: implement runtime configuration package with multi-org support#14470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Closed
Changes from1 commit
Commits
Show all changes
19 commits Select commitHold shift + click to select a range
5c92688
Implementation
dannykopping03ecbac
Support zero values
dannykoppingf97ca89
Add database queries against site_configs
dannykoppingb2b43c8
Document usage in test
dannykoppinge67da12
Touchups
dannykopping127f1cc
make gen to generate dbmock functions
Emyrk43e9e85
make lint/fmt
dannykoppingfa7193e
Initializer interface, rename "key" to "name"
dannykopping31f8cbf
Manager interface
dannykopping048506d
Manager, with scoping
dannykopping1940ca0
linting errors
Emyrkd8ad4d4
chore: add runtimeconfig manager to options for plumbing (#14562)
Emyrkf44f1c7
linting, remove unused ctx
Emyrk7452a23
chore: refactor entry into deployment and runtime (#14575)
Emyrk13ea99a
chore: comments, cleanup, error fixes
Emyrk7d08255
increase test coverage:
Emyrk4ec16cd
linting complained about an unhandled Println error
Emyrk9f546d0
drop manager interface, wrap errors
Emyrk56f4df2
rename NewStoreManager -> NewManager
EmyrkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Manager interface
Signed-off-by: Danny Kopping <danny@coder.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit31f8cbfe6a73425bedd7d1d95f5e2444ccba77c7
There are no files selected for viewing
23 changes: 23 additions & 0 deletionscoderd/runtimeconfig/spec.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.