- Notifications
You must be signed in to change notification settings - Fork913
fix: support additional http headers on agent#14464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ethanndickson merged 1 commit intomainfrom08-28-fix_support_additional_http_headers_on_agentAug 29, 2024
Merged
fix: support additional http headers on agent#14464
ethanndickson merged 1 commit intomainfrom08-28-fix_support_additional_http_headers_on_agentAug 29, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
cd4d42b to5510d59Comparedeansheather approved these changesAug 29, 2024
Uh oh!
There was an error while loading.Please reload this page.
e65eb03 intomain 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#14462.
Currently, the
agentsubcommand does not consumeCODER_HEADER/--headerorCODER_HEADER_COMMAND/--header-command.This PR adds
CODER_AGENT_HEADER/--agent-headerandCODER_AGENT_HEADER_COMMAND/--agent-header-commandinstead of consuming the global ones.This was done as other options for agent authentication differentiate themselves by using an agent prefix (token, url, token_file), to avoid unintentionally populating the options on an agent using a client configuration.
#11901 will likely supersede this, long-term.