Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: improve custom roles create/edit page#14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 5 commits intomainfromjaaydenh/custom-roles-improvements
Aug 28, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedAug 27, 2024•
edited
Loading

Resolves#14311

  • Add a parent checkbox for resource/action groups to check/uncheck all actions for that resource.
  • Change "Show all permissions" to "Show advanced permissions"
  • "Show advanced permissions" should change to "Hide advanced permissions". Currently the text does not change on being clicked.
  • Align action description text
Screenshot 2024-08-27 at 2 25 03 PM

BrunoQuaresma reacted with hooray emoji
@jaaydenhjaaydenh self-assigned thisAug 27, 2024
@jaaydenhjaaydenh changed the titlefeat: improvements for custom roles create/edit pagefeat: improve custom roles create/edit pageAug 27, 2024
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🥂

}),
actionItem: {
display: "grid",
gridTemplateColumns: "270px 3fr",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ultra nit: this could be1fr since there aren't any other columns taking fractions

jaaydenh reacted with thumbs up emoji
@BrunoQuaresma
Copy link
Collaborator

Minor design considerations:

Screen.Recording.2024-08-28.at.09.40.48.mp4

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I noticed the tests for some of the points you mentioned in the PR description are missing. Could you add those?

@jaaydenh
Copy link
ContributorAuthor

I noticed the tests for some of the points you mentioned in the PR description are missing. Could you add those?

I could add a storybook for the indeterminate state of the parent checkbox. What other types of tests are you thinking of?

@jaaydenh
Copy link
ContributorAuthor

@BrunoQuaresma I added 2 additional stories for now, there is definitely a learning curve for figuring out the best way to query all the elements needed for the tests.

@jaaydenhjaaydenh merged commit15d74a1 intomainAug 28, 2024
28 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/custom-roles-improvements branchAugust 28, 2024 22:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma left review comments

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements for custom roles create/edit page
3 participants
@jaaydenh@BrunoQuaresma@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp