Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): add aws check to ping p2p diagnostics#14450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 27, 2024•
edited
Loading

Continues to address#14244.

If the client or agent's public IP is within an AWS range,coder ping will now report that it is behind a hard NAT, which may impede forming a direct connection.

Additionally informs if the client or agent was unable to contact a STUN server over UDP, if the DERP map contains a STUN server.

Output format:

[...]✔ Wireguard handshake 12s ago❗ You are connected via a DERP relay, not directly (p2p)❗ Network interface eth0 has MTU 1280, (less than 1378), which may degrade the quality of direct connectionsPossible client-side issues with direct connection: - Reason 1  - Reason 2Possible agent-side issues with direct connections:  - Reason 1    - Reason 2

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 27, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 27, 2024 09:07

// CheckIP checks if the given IP address is an AWS IP.
func (r *AWSIPRanges) CheckIP(ip netip.Addr) (bool, error) {
if ip.IsLoopback() || ip.IsLinkLocalMulticast() || ip.IsLinkLocalUnicast() || ip.IsPrivate() {
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We shouldn't be given these IP classes incoder ping, but this is in case we ever wanted to re-use this util.

@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch fromdf1bee7 to9117628CompareAugust 28, 2024 02:54
@ethanndicksonethanndicksonforce-pushed the08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branch from41ab80f toa92e814CompareAugust 28, 2024 02:54
@ethanndicksonethanndickson changed the base branch from08-26-feat_cli_add_p2p_diagnostics_to_ping tographite-base/14450August 28, 2024 05:39
@ethanndicksonethanndicksonforce-pushed the08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branch froma92e814 to15438e6CompareAugust 28, 2024 05:39
@ethanndicksonethanndickson changed the base branch fromgraphite-base/14450 tomainAugust 28, 2024 05:39
@ethanndicksonethanndicksonforce-pushed the08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branch 5 times, most recently from461723e to788ff3aCompareAugust 29, 2024 05:08
Copy link
Contributor

@spikecurtisspikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So, not necessarily in this PR, but part of this work is thatevery diagnostic check should have a corresponding page/section in our docs and we should include the link in the CLI output

a la

You are connected via a DERP relay, not directly, peer-to-peer (p2p).Possible client-side issues with direct connection:- We detected an endpoint firewall that could be blocking UDP from the agent.  https://docs.coder.com/<whatever>

ethanndickson reacted with thumbs up emoji
@ethanndicksonethanndicksonforce-pushed the08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branch from788ff3a to9ccec94CompareAugust 29, 2024 08:17
@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedAug 29, 2024•
edited
Loading

New output format:

[...]✔ Wireguard handshake 12s ago❗ You are connected via a DERP relay, not directly (p2p)❗ Network interface eth0 has MTU 1280, (less than 1378), which may degrade the quality of direct connectionsPossible client-side issues with direct connection: - Reason 1  - Reason 2Possible agent-side issues with direct connections:  - Reason 1    - Reason 2

Fixing the test I broke...

@ethanndicksonethanndicksonforce-pushed the08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branch frome162ec9 to2e08d19CompareAugust 29, 2024 11:19
@ethanndicksonethanndickson merged commit4b5c45d intomainAug 29, 2024
28 checks passed
@ethanndicksonethanndickson deleted the 08-27-feat_cli_add_aws_check_to_ping_p2p_diagnostics branchAugust 29, 2024 11:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 29, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@spikecurtisspikecurtisspikecurtis approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ethanndickson@spikecurtis@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp