- Notifications
You must be signed in to change notification settings - Fork928
feat: addtemplates delete command#1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is what I like to see Mr. Adler! |
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| var ( | ||
| ctx = cmd.Context() | ||
| templateNames = []string{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This can only be a max of 1 right? I don't believe this needs to be an array!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I forgot to remove the max 1 limit! I think it's nicer if we take in more than one since it plays nicer with xargs.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ish
cli/templatedelete.go Outdated
| func templateDelete() *cobra.Command { | ||
| return &cobra.Command{ | ||
| Use: "delete [name...]", | ||
| Short: "Delete templates.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure this is a sentence
Uh oh!
There was an error while loading.Please reload this page.
Resolves#1204