Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(cli): add p2p diagnostics to ping#14426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 26, 2024•
edited
Loading

First PR to address#14244.

Adds common potential reasons as to why a direct connection to the workspace agent couldn't be established tocoder ping:

  • If the Coder deployment administrator has blocked direction connections (CODER_BLOCK_DIRECT).
  • If the client has no STUN servers within it's DERP map.
  • If the client or agent appears to be behind a hard NAT, as per TailscalenetInfo.MappingVariesByDestIP

Also adds a warning if the client or agent has a network interface below the 'safe' MTU for tailnet. This warning is always displayed at the end of acoder ping.

@ethanndicksonGraphite App
Copy link
MemberAuthor

ethanndickson commentedAug 26, 2024•
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently from6b50ee0 toda189aeCompareAugust 26, 2024 08:43
@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently from62ef172 to5e7d212CompareAugust 26, 2024 12:31
@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch from5e7d212 toc8a7222CompareAugust 27, 2024 05:31
@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 27, 2024 05:33
@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch 2 times, most recently fromb48a21d to047e871CompareAugust 27, 2024 05:41
@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch from047e871 to5db04cdCompareAugust 27, 2024 06:19
@ethanndicksonethanndicksonforce-pushed the08-26-feat_cli_add_p2p_diagnostics_to_ping branch fromdf1bee7 to9117628CompareAugust 28, 2024 02:54
@ethanndicksonethanndickson merged commit8c15192 intomainAug 28, 2024
28 checks passed
@ethanndicksonethanndickson deleted the 08-26-feat_cli_add_p2p_diagnostics_to_ping branchAugust 28, 2024 05:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

@sreyasreyaAwaiting requested review from sreya

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ethanndickson@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp