- Notifications
You must be signed in to change notification settings - Fork1.1k
chore: implement generalized symmetric difference for set comparison#14407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Going to be used in Organization Sync + maybe group sync. Feltbetter to reuse, rather than copy
Emyrk commentedAug 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed by Graphite.Learn more about stacking. |
johnstcn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.

Uh oh!
There was an error while loading.Please reload this page.
Symmetric difference in set theory is used to determine which elements need to be added/removed to go from set
Ato setB. We use this atm when determining which roles are added/removed when changing a user's permissions.This same logic can be applied to organization sync (WIP) and group sync (WIP). Felt better to just make it a generalized slice function. This code is slightly less efficient since a map was used before for membership, but the slices we are working with are small anyway.