Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: implement generalized symmetric difference for set comparison#14407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 6 commits intomainfromstevenmasley/symmetric_difference
Aug 23, 2024

Conversation

@Emyrk
Copy link
Member

@EmyrkEmyrk commentedAug 22, 2024
edited
Loading

Symmetric difference in set theory is used to determine which elements need to be added/removed to go from setA to setB. We use this atm when determining which roles are added/removed when changing a user's permissions.

This same logic can be applied to organization sync (WIP) and group sync (WIP). Felt better to just make it a generalized slice function. This code is slightly less efficient since a map was used before for membership, but the slices we are working with are small anyway.

Going to be used in Organization Sync + maybe group sync. Feltbetter to reuse, rather than copy
@EmyrkGraphite App
Copy link
MemberAuthor

Emyrk commentedAug 22, 2024
edited
Loading

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@Emyrk and the rest of your teammates onGraphiteGraphite

@EmyrkEmyrk marked this pull request as ready for reviewAugust 22, 2024 22:07
@EmyrkEmyrk requested a review fromjohnstcnAugust 22, 2024 22:40
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!

@EmyrkEmyrk merged commitcb6a472 intomainAug 23, 2024
@EmyrkEmyrk deleted the stevenmasley/symmetric_difference branchAugust 23, 2024 19:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@EmyrkEmyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emyrk@johnstcn

[8]ページ先頭

©2009-2025 Movatter.jp