Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: filter "add group member" by organization#14404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 3 commits intomainfromasher/filter-member-add
Aug 26, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 22, 2024•
edited
Loading

This is accomplished by using the members endpoint instead of the users endpoint, and to that end the UserAutocomplete component has been reworked to support either endpoint as separate components with a shared base.

This only affects the group page under organizations, the original one (which shows when the multi-org experiment is disabled) remains unaffected. The org group page dropdown should now only show users belonging to the organization instead of all the users in the deployment.

Closes#13915

Emyrk reacted with thumbs up emoji
@code-ashercode-asher changed the titlefix: filter add group member by organizationfix: filter "add group member" by organizationAug 22, 2024
@code-ashercode-asher marked this pull request as ready for reviewAugust 22, 2024 21:19
@code-ashercode-asher requested review froma team andBrunoQuaresma and removed request fora teamAugust 22, 2024 21:19
This is accomplished by using the members endpoint instead of the usersendpoint, and to that end the UserAutocomplete component has beenreworked to support either endpoint as separate components with a sharedbase.
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good to me and works as expected, but I’m missing an integration test to make this behavior more intentional and to prevent us from accidentally removing or replacing it in the future.

@code-asher
Copy link
MemberAuthor

Fair, let me add one on the group page.

This ensures it is using the right endpoint for the add member dropdown.
@code-asher
Copy link
MemberAuthor

code-asher commentedAug 23, 2024•
edited
Loading

@BrunoQuaresma I added a Storybook testing the integration but do you know if there is a way to mock errors with react-query? I see we usesetQueryData() to mock the data but it does not look like there is a way to mock errors. Right now I have it just actually making the query, which of course then fails with a 404, that way I can test the errors in Storybook, but it feels kinda bad to do it that way.

I could also split it off into a view and then test that instead.

@code-asher
Copy link
MemberAuthor

I figured out a way to do it, but let me know if there is a better way

BrunoQuaresma reacted with thumbs up emoji

@BrunoQuaresma
Copy link
Collaborator

@code-asher it looks good enough for me 🚢 it

code-asher reacted with rocket emoji

@code-ashercode-asher merged commit88d7181 intomainAug 26, 2024
28 checks passed
@code-ashercode-asher deleted the asher/filter-member-add branchAugust 26, 2024 19:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaAwaiting requested review from BrunoQuaresma

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solidify permissions and licensing checks in the UI for Org feature set
2 participants
@code-asher@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp