Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: set network telemetry client version on server#14376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedAug 21, 2024•
edited
Loading

Also removes theDisconnectionReason field, given that it was unused. Requires a corresponding change on the telemetry server.

Closes#14375

@ethanndicksonethanndickson marked this pull request as ready for reviewAugust 21, 2024 06:51
@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphiteGraphite

@ethanndicksonethanndicksonforce-pushed the08-21-fix_set_network_telemetry_client_version_on_server branch 2 times, most recently from658f6f9 toec124baCompareAugust 21, 2024 08:27
Copy link
Collaborator

@sreyasreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There aren't any tests to prevent this from happening in the future. Is there an opportunity to introduce some?

@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedAug 22, 2024•
edited
Loading

I think it'd be beneficial to have an E2E network telemetry test. We'd just need to mock the telemetry batcher on a coderdtest instance so we can inspect it.

@sreya
Copy link
Collaborator

@ethanndickson there's already atelemetry_test.go file but we haven't added any tests to it related to networking events.

@ethanndickson
Copy link
MemberAuthor

ethanndickson commentedAug 22, 2024•
edited
Loading

Unfortunately I don't believe we expose anything like/snapshot on coderd to inspect the network events, unlike the other telemetry - so it'll likely end up being done differently.

@ethanndicksonethanndicksonforce-pushed the08-21-fix_set_network_telemetry_client_version_on_server branch fromec124ba to64b79cdCompareAugust 23, 2024 06:07
@ethanndicksonethanndicksonenabled auto-merge (squash)August 23, 2024 06:07
@ethanndicksonethanndickson merged commit4cc26be intomainAug 23, 2024
28 checks passed
@ethanndicksonethanndickson deleted the 08-21-fix_set_network_telemetry_client_version_on_server branchAugust 23, 2024 06:17
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@sreyasreyasreya left review comments

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client_version not being set for networking telemetry
3 participants
@ethanndickson@sreya@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp