- Notifications
You must be signed in to change notification settings - Fork1.1k
feat(coderd): enable setting max port share level during template creation#14366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(coderd): enable setting max port share level during template creation#14366
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ethanndickson commentedAug 20, 2024
This stack of pull requests is managed by Graphite.Learn more about stacking. Join@ethanndickson and the rest of your teammates on |
alwaysmeticulousbot commentedAug 20, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Meticulous spotted zero visual differences across 1408 screens tested:view results. Expected differences?Click here. Last updated for commitb4ba88c. This comment will update as new commits are pushed. |
c73e535 tofa16bf0Compare| } | ||
| } | ||
| ifcreateTemplate.MaxPortShareLevel!=nil { | ||
| err=portSharer.ValidateTemplateMaxLevel(*createTemplate.MaxPortShareLevel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Of note is that this will always error for AGPL deployments.
fa16bf0 to9b5e512Compare9b5e512 tob4ba88cCompare
Uh oh!
There was an error while loading.Please reload this page.
Previously, the max port share level could only be set during template metadata updates. It can now be set during creation, but only for enterprise deployments.
This change is most useful for the
coderdprovider, which can now set the max port share level during creation, without needing to make another request.