NotificationsYou must be signed in to change notification settings
Fork911
Star10k

feat(coderd): enable setting max port share level during template creation#14366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ethanndickson merged 1 commit intomainfrom08-20-feat_enable_setting_max_port_share_level_during_template_creation

Aug 20, 2024

Merged

feat(coderd): enable setting max port share level during template creation#14366

ethanndickson merged 1 commit intomainfrom08-20-feat_enable_setting_max_port_share_level_during_template_creation

Aug 20, 2024

Conversation

Copy link

Member

ethanndickson commentedAug 20, 2024•
edited
Loading

Previously, the max port share level could only be set during template metadata updates. It can now be set during creation, but only for enterprise deployments.

This change is most useful for thecoderd provider, which can now set the max port share level during creation, without needing to make another request.

github-actionsbot assignedethanndickson

Aug 20, 2024

Copy link

MemberAuthor

ethanndickson commentedAug 20, 2024

feat(coderd): enable setting max port share level during template creation #14366 👈
main

This stack of pull requests is managed by Graphite.Learn more about stacking.

Join@ethanndickson and the rest of your teammates onGraphite

Copy link

alwaysmeticulousbot commentedAug 20, 2024•
edited
Loading

✅ Meticulous spotted zero visual differences across 1408 screens tested:view results.

_{Expected differences?Click here. Last updated for commitb4ba88c. This comment will update as new commits are pushed.}

ethanndickson marked this pull request as ready for review

August 20, 2024 12:16

ethanndickson changed the title~~feat: enable setting max port share level during template creation~~feat(api): enable setting max port share level during template creation

Aug 20, 2024

ethanndickson changed the title~~feat(api): enable setting max port share level during template creation~~feat(coderd): enable setting max port share level during template creation

Aug 20, 2024

ethanndickson force-pushed the08-20-feat_enable_setting_max_port_share_level_during_template_creation branch fromc73e535 tofa16bf0Compare

August 20, 2024 12:24

ethanndickson requested a review fromdeansheather

August 20, 2024 12:25

ethanndickson commented

Aug 20, 2024

View reviewed changes

coderd/templates.go

		@@ -329,6 +331,14 @@ func (api API) postTemplateByOrganization(rw http.ResponseWriter, r http.Reque
		validErrs = append(validErrs, codersdk.ValidationError{Field: "autostart_requirement.days_of_week", Detail: err.Error()})
		}
		}
		if createTemplate.MaxPortShareLevel != nil {
		err = portSharer.ValidateTemplateMaxLevel(*createTemplate.MaxPortShareLevel)