Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: label premium features in middleware error#14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 7 commits intomainfromasher/org-is-premium
Aug 19, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 19, 2024•
edited
Loading

@Emyrk is this verbiage correct? Currently in the frontend I am naming the license as "premium", distinct from "enterprise", so I wanted to update the backend error message as well, but if this is wrong let me know and I will change the frontend too.

The capitalization seems weird to me, but keeping it since it was already there.

Cleanup item for#13915

@code-ashercode-asher changed the titlefix: Report multiple organizations as a premium featurefix: report multiple organizations as a premium featureAug 19, 2024
@code-ashercode-asher changed the titlefix: report multiple organizations as a premium featurefix: mark multiple organizations as a premium featureAug 19, 2024
@code-ashercode-asher changed the titlefix: mark multiple organizations as a premium featurefix: label multiple organizations as premium in middleware errorAug 19, 2024
@code-ashercode-asher requested a review fromEmyrkAugust 19, 2024 23:06
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Verbiage is correct 👍

@code-asher
Copy link
MemberAuthor

code-asher commentedAug 19, 2024•
edited
Loading

Thank you for confirming! I added a test as well, to mirror the one we have for custom roles. Did some brief smoke testing as well.

@code-ashercode-asher changed the titlefix: label multiple organizations as premium in middleware errorfix: label premium features in middleware errorAug 19, 2024
@code-ashercode-asher merged commitf8f3d89 intomainAug 19, 2024
30 checks passed
@code-ashercode-asher deleted the asher/org-is-premium branchAugust 19, 2024 23:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@code-asher@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp