- Notifications
You must be signed in to change notification settings - Fork928
feat: add autostart/autostop show, show autostart/autostop schedule in ls output#1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedMay 13, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## main #1436 +/- ##==========================================- Coverage 67.26% 67.04% -0.23%========================================== Files 288 284 -4 Lines 19422 19297 -125 Branches 244 244 ==========================================- Hits 13065 12938 -127- Misses 5019 5020 +1- Partials 1338 1339 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Couple of minor issues with the message formatting, but other than that LGTM.
cli/autostart.go Outdated
| } | ||
| if workspace.AutostartSchedule == "" { | ||
| _, _ = fmt.Fprintf(cmd.OutOrStdout(), "not enabled") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this and some of the otherfmt.Fprintf calls inautostart.go andautostop.go are missing trailing newlines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
whoops!
cli/autostart.go Outdated
| return nil | ||
| } | ||
| _, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nschedule: %s\nnext: %s\n", workspace.AutostartSchedule, validSchedule.Next(time.Now())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there any particular reason for printing an extra blank line at the beginning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Probably because I yanked the line from somewhere else and forgot to clean it up 🙃
…n ls output (#1436)* feat: add autostart/autostop show, show autostart/autostop schedule in ls output
Uh oh!
There was an error while loading.Please reload this page.
Slipped my mind to do this before 🤦
Closes#1431