Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update secondary and disabled text colors#14355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 1 commit intomainfromjaaydenh/secondary-text-colors
Aug 26, 2024

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedAug 19, 2024•
edited
Loading

The goal of this PR is to increase the contrast between the primary and secondary text to make it a little clearer to see what the relationship of information in the UI. This brings the design more in line with products such as Vercel that use a higher contrast between primary and secondary text.

Dark ---------

dark-olddark-new

Blue ---------
blue-old
blue-new

White ---------
white-old
white-new

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 19, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 1473 of 1477 screens tested:view and approve differences detected.

Meticulous tested100% of the executable lines edited in this PR.

Last updated for commite43f487. This comment will update as new commits are pushed.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Just be sure you go through all the Chromatic changes very carefully 🙏

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

seconding what Bruno said, but it looks good from the screenshots!

@jaaydenhjaaydenh merged commitfb6b954 intomainAug 26, 2024
34 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/secondary-text-colors branchAugust 26, 2024 16:22
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@jaaydenh@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp