Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: sign the windows installer#14353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kylecarbs merged 1 commit intomainfromsignwindowsinstaller
Aug 20, 2024
Merged

Conversation

kylecarbs
Copy link
Member

We have been signing all Windows executablees, but not the installer.

@kylecarbskylecarbs self-assigned thisAug 19, 2024
We have been signing all Windows executablees, but not the installer.
@matifali
Copy link
Member

matifali commentedAug 19, 2024•
edited
Loading

Do we get any benefit of installer? Can we drop installer in favor of zipped binaries?
As far as I remember we added the installer to support Winget which doesn't need it anymore.
cc:@deansheather

@kylecarbs
Copy link
MemberAuthor

The installer automatically adds Coder to thePATH, which is nice. It's a similar feel todpkg -i on Linux.

ericpaulsen reacted with laugh emoji

@kylecarbskylecarbs merged commit6f9b3c1 intomainAug 20, 2024
@kylecarbskylecarbs deleted the signwindowsinstaller branchAugust 20, 2024 00:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 20, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@kylecarbskylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@kylecarbs@matifali@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp