Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: ui error handling should be specific to general#14346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 6 commits intomainfromstevenmasley/ui_error_display
Aug 19, 2024

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedAug 19, 2024•
edited
Loading

Specific errors should be checked before defaulting to a general error handling.

I noticed the error details were not being shown in my manual testing. We should check for axios error before defaulting to a general string.

Specific errors should be checked before defaulting to a generalerror handling
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 19, 2024•
edited
Loading

✅ Meticulous spotted zero visual differences across 1477 screens tested:view results.

Meticulous tested100% of the executable lines edited in this PR.

Expected differences?Click here. Last updated for commit1b39235. This comment will update as new commits are pushed.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you think you could add a test for this?

@Emyrk
Copy link
MemberAuthor

Do you think you could add a test for this?

Added a story book 👍

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for the test!

@EmyrkEmyrk merged commit755afa3 intomainAug 19, 2024
29 checks passed
@EmyrkEmyrk deleted the stevenmasley/ui_error_display branchAugust 19, 2024 18:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma left review comments

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Emyrk@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp