Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: show org summary page if not entitled#14336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 1 commit intomainfromasher/org-summary-if-not-entitled
Aug 19, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 17, 2024
edited
Loading

Cleaning up some things from#13915

You cannot edit the org settings without being entitled, so show the summary page instead.

I am really not sure this is the best long-term solution, but it at least prevents folks from submitting a form that will just error. Possibly we should also add a banner or something that says "if you want to edit this organization you need a license".

Hiding the org(s) on the sidebar entirely would also be an option, but, if they were previously licensed and it expired or something would it cause unnecessary panic that the org(s) suddenly disappeared?

And it does seem a little weird to me somehow to have a new org link but not be listing the orgs that exist even if it is just the default org, although I cannot quite put my finger on why. Might just generally be my preference to show everything but disable as necessary over hiding things.

I suppose we could hide the entire organizations section along with the new org link, but then how would you discover that orgs are a thing? Currently if you go into the new org page you can learn that a license is required. We could have just the organizations heading and then a small sidebar version of the license banner, maybe?

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 17, 2024
edited
Loading

🤖 Meticulous spotted visual differences in 2 of 1428 screens tested:view and approve differences detected.

Meticulous tested4/5 of the executable lines edited in this PR1.

1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Last updated for commitfc7e2d4. This comment will update as new commits are pushed.

You cannot edit the settings without being entitled, so show the summarypage instead.
@code-ashercode-asherforce-pushed theasher/org-summary-if-not-entitled branch from9ef3da7 tofc7e2d4CompareAugust 17, 2024 00:32
@code-ashercode-asher merged commit4446d61 intomainAug 19, 2024
30 checks passed
@code-ashercode-asher deleted the asher/org-summary-if-not-entitled branchAugust 19, 2024 23:57
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@code-asher@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp