Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update editorconfig with new tabs default#14335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 3 commits intomainfromasher/update-editorconfig
Aug 19, 2024

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 16, 2024
edited
Loading

I explicitly addedtsx andts since I am not sure if we have other file types that got changed to tabs, lemme know if I missed some.

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 16, 2024
edited
Loading

✅ Meticulous spotted zero visual differences across 1477 screens tested:view results.

Expected differences?Click here. Last updated for commite595808. This comment will update as new commits are pushed.

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oh! I didn't notice we had a second one of these inside site/. good catch!

I think it makes more sense to change the default though (since basically every file in this folder should use tabs now) rather than add them as an exception.

Something like...

[*]indent_style = tabindent_size = 2[node_modules/**]ignore = true

(settingsindent_size is actually still important for non-obvious reasons)

@code-asher
Copy link
MemberAuthor

Makes sense to me! Good point onindent_size, I noticed some odd behavior there only in ts(x) files but thought maybe my editor was just being weird.

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

beautiful!

@code-asher
Copy link
MemberAuthor

Actually, doesindent_size take away people's visual tab width preference? Some reading I was doing suggests it might. I tried unsettingindent_size again and maybe it was just my editor being weird, it seems to work OK.

@aslilac
Copy link
Member

I would hope not, but it can be important for stuff like yaml files that don't support tab indentation. we can try leaving it unset for now if you'd like, and we can always set it later if it's causing issues.

code-asher reacted with thumbs up emoji

@code-asher
Copy link
MemberAuthor

code-asher commentedAug 19, 2024
edited
Loading

Sweet, lemme unset it for now then. I just did some brief testing with VS Code and the editorconfig plugin and it did change the visual tab width which seems kinda insane to me but I suppose it is what it is

@code-ashercode-asher merged commitfa59b30 intomainAug 19, 2024
@code-ashercode-asher deleted the asher/update-editorconfig branchAugust 19, 2024 19:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@code-ashercode-asher

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@code-asher@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp