NotificationsYou must be signed in to change notification settings
Fork928
Star10.1k

refactor: Improve the load state for the list pages#1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

BrunoQuaresma merged 10 commits intomainfrombq/refactor-full-page-loader-design

May 13, 2022

Merged

refactor: Improve the load state for the list pages#1428

BrunoQuaresma merged 10 commits intomainfrombq/refactor-full-page-loader-design

May 13, 2022

Conversation

Copy link

Collaborator

BrunoQuaresma commentedMay 13, 2022

The old loading state was blocking the full page and it was not looking quite good so I fixed it as a brain break
UpdatedWorkspacesPage andWorkspacePage to use not use the customTable component and created the componentsWorkspacesTable andTemplatesTable with related storybooks covering theempty,default andloading states so we can trust on storybook to test them for us.
I also made some minor updates in the EmptyState to looks slightly better.

BrunoQuaresma added8 commits

May 12, 2022 17:46

Improve loading for Users

4cef295

Refactor templates table

c0824d5

Add total label

e1e6d9d

Improve empty state

40afc47

Refactor template page to use MUI table

c76d68c

Add templates table

6b37868

Add workspaces table

b3bdc36

Add loading states on storybook

8524f1f

BrunoQuaresma self-assigned this

May 13, 2022

BrunoQuaresma requested review frompresleyp anda team ascode owners

May 13, 2022 17:03

Merge branch 'main' of github.com:coder/coder into bq/refactor-full-p…

036d18f

…age-loader-design

Copy link

codecovbot commentedMay 13, 2022•
edited
Loading

Codecov Report

Merging#1428 (f52bb68) intomain (9410237) willdecrease coverage by0.08%.
The diff coverage is27.65%.

@@            Coverage Diff             @@##             main    #1428      +/-   ##==========================================- Coverage   67.26%   67.18%   -0.09%==========================================  Files         288      291       +3       Lines       19422    19452      +30       Branches      244      258      +14     ==========================================+ Hits        13065    13068       +3- Misses       5019     5046      +27  Partials     1338     1338

Flag	Coverage Δ
unittest-go-macos-latest	`54.17% <ø> (+0.06%)`	⬆️
unittest-go-postgres-	`65.68% <ø> (-0.07%)`	⬇️
unittest-go-ubuntu-latest	`56.65% <ø> (+0.04%)`	⬆️
unittest-go-windows-2022	`52.60% <ø> (-0.04%)`	⬇️
unittest-js	`74.73% <27.65%> (-0.54%)`	⬇️

Impacted Files	Coverage Δ
...e/src/components/TemplatesTable/TemplatesTable.tsx	`0.00% <0.00%> (ø)`
...src/components/WorkspacesTable/WorkspacesTable.tsx	`0.00% <0.00%> (ø)`
...ges/OrganizationPage/TemplatePage/TemplatePage.tsx	`0.00% <0.00%> (ø)`
site/src/pages/TemplatesPages/TemplatesPage.tsx	`0.00% <0.00%> (ø)`
site/src/pages/UsersPage/UsersPageView.tsx	`94.44% <ø> (ø)`
site/src/xServices/users/usersXService.ts	`72.91% <ø> (ø)`
site/src/pages/UsersPage/UsersPage.tsx	`91.42% <70.00%> (+4.58%)`	⬆️
site/src/components/UsersTable/UsersTable.tsx	`96.55% <85.71%> (+0.55%)`	⬆️
site/src/components/EmptyState/EmptyState.tsx	`100.00% <100.00%> (+14.28%)`	⬆️
site/src/components/Loader/FullScreenLoader.tsx	`100.00% <100.00%> (ø)`
... and12 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update9410237...f52bb68. Read thecomment docs.