- Notifications
You must be signed in to change notification settings - Fork927
chore: update envbox template image#14256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedAug 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity added a commit to coder/cla that referenced this pull requestAug 13, 2024
The referenced image seems to be a deprecated version of the enterprise-base image
Update the installation to match the other templates, in particular:* Install using standalone method* Install to /tmp* Close parent stderr stream (write code-server stderr to log file)
68ae389
tod90fb01
Comparedeansheather approved these changesAug 14, 2024
Tested on dev.coder.com and it works fine. |
86b9c97
intocoder:main 27 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thank you for your contribution! 🚀 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Updated installation of
code-server
to be consistent with the other templates using the same method as#6138This fixes an error where the
stderr
stream ofcode-server
wasn't correctly redirected to the log fileAlso updated the image used in the "inner container" of the
envbox
template and removed unnecessarysensitive
designation on template variables.I tested the new template to verify it creates a workspace without error. I verified that
systemd
anddocker
appear to be working normally in the workspace.