Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: filter templates by organization#14254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 9 commits intomainfromfilter-templates-by-org
Aug 14, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedAug 12, 2024
edited
Loading

Add support for filtering templates based on the organization they belong to.

As a bonus, since the backend already supports it, you can filter bydeprecated andname as well.

Screenshot 2024-08-13 at 11 30 57 AM

@aslilacaslilac marked this pull request as draftAugust 12, 2024 23:22
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 13, 2024
edited
Loading

🤖 Meticulous spotted visual differences in 67 of 1191 screens tested:view and approve differences detected.

Meticulous tested104/112 of the executable lines edited in this PR1.

1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Last updated for commit6a2fafd. This comment will update as new commits are pushed.

@aslilacaslilac marked this pull request as ready for reviewAugust 13, 2024 22:38
@jaaydenh

This comment was marked as resolved.

@jaaydenh

This comment was marked as resolved.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good, but I'm missing tests for this feature.

Minor things that I found during QA:

  1. Should we display the count information at the top of the table, as we do for workspaces and other pages with filters?
Screenshot 2024-08-14 at 10 01 49
  1. I think we should only display the following content when it is empty, with no filters applied, or when there are no active templates.
Screenshot 2024-08-14 at 10 02 56

In my opinion, these are not blockers—perhaps the tests could be considered—but I'll trust your judgment, so I'm approving this. 👍

@aslilac
Copy link
MemberAuthor

@BrunoQuaresma

  1. I'm going with no for now. This view isn't paginated, whereas the views that show this are. If we ever add pagination tho, definitely!

  2. Yeah, we should probably tweak this, but this feels good enough for the experiment. I'll make a note about revisiting it for GA.

BrunoQuaresma reacted with thumbs up emoji

@aslilacaslilac merged commit8563b37 intomainAug 14, 2024
32 checks passed
@aslilacaslilac deleted the filter-templates-by-org branchAugust 14, 2024 21:01
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh left review comments

@EmyrkEmyrkEmyrk left review comments

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aslilac@jaaydenh@BrunoQuaresma@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp