- Notifications
You must be signed in to change notification settings - Fork927
feat: filter templates by organization#14254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alwaysmeticulousbot commentedAug 13, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🤖 Meticulous spotted visual differences in 67 of 1191 screens tested:view and approve differences detected. Meticulous tested104/112 of the executable lines edited in this PR1. 1. These lines will likely automatically gain test coverage over the coming days, however if you wish to increase coverage immediately you can do so by interacting with your feature on localhost. Last updated for commit6a2fafd. This comment will update as new commits are pushed. |
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code looks good, but I'm missing tests for this feature.
Minor things that I found during QA:
- Should we display the count information at the top of the table, as we do for workspaces and other pages with filters?

- I think we should only display the following content when it is empty, with no filters applied, or when there are no active templates.

In my opinion, these are not blockers—perhaps the tests could be considered—but I'll trust your judgment, so I'm approving this. 👍
Uh oh!
There was an error while loading.Please reload this page.
|
8563b37
intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Add support for filtering templates based on the organization they belong to.
As a bonus, since the backend already supports it, you can filter by
deprecated
andname
as well.