Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: use insert and delete instead of upsert for custom roles#14252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jaaydenh
Copy link
Contributor

resolves#14245

@EmyrkEmyrkforce-pushed thestevenmasley/custom_role_remove_upsert branch from14da05a toc567a9dCompareAugust 12, 2024 21:24
@jaaydenhjaaydenhforce-pushed thecustom-role-remove-upsert-frontend branch fromffa67cf to7042119CompareAugust 12, 2024 21:47
@jaaydenhjaaydenh requested a review fromaslilacAugust 12, 2024 21:52
Comment on lines 59 to 65
if (role) {
await updateOrganizationRoleMutation.mutateAsync(data);
navigate(`/organizations/${organizationName}/roles`);
} else {
await createOrganizationRoleMutation.mutateAsync(data);
navigate(`/organizations/${organizationName}/roles`);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
if(role){
awaitupdateOrganizationRoleMutation.mutateAsync(data);
navigate(`/organizations/${organizationName}/roles`);
}else{
awaitcreateOrganizationRoleMutation.mutateAsync(data);
navigate(`/organizations/${organizationName}/roles`);
}
if(role){
awaitupdateOrganizationRoleMutation.mutateAsync(data);
}else{
awaitcreateOrganizationRoleMutation.mutateAsync(data);
}
navigate(`/organizations/${organizationName}/roles`);

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 13, 2024
edited
Loading

🤖 Meticulous replayed 100 user sessions andtook 1355 visual snapshots. Meticulous has not yet run onc567a9d of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons fornew pull requests after the next commit to the main branch.

Last updated for commit161ee26. This comment will update as new commits are pushed.

@jaaydenhjaaydenh merged commit05f1814 intostevenmasley/custom_role_remove_upsertAug 13, 2024
30 checks passed
@jaaydenhjaaydenh deleted the custom-role-remove-upsert-frontend branchAugust 13, 2024 16:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp