Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: move api and cli docs routes to reference/#14241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 16 commits intomainfrommatifali/move-refrences
Aug 13, 2024

Conversation

matifali
Copy link
Member

@matifalimatifali commentedAug 12, 2024
edited
Loading

As part of#13434, this PR moves CLI and API docs under reference.

This will help reduce the size of#14182.

we need to create redirects from docs/[cli,api] to docs/reference/[cli,api]

Docs link check is passing so it should be fine to merge.

@matifalimatifali requested a review fromstirbyAugust 12, 2024 15:02
@matifalimatifali added the docsArea: coder.com/docs labelAug 12, 2024
@kylecarbs
Copy link
Member

Do the routes need to be nested like that? The redirects feel unnecessary.

@matifalimatifali changed the titledocs: move api and cli docs under referencedocs: move api and cli docs to referenceAug 12, 2024
@matifali
Copy link
MemberAuthor

The redirects feel unnecessary.

@kylecarbs Aren't redirects required for any old links to work? in case someone is using those links in any internal docs?

Do the routes need to be nested like that?

I fixed the manifest. Routes are now nested under Reference.

@matifalimatifali changed the titledocs: move api and cli docs to referencedocs: move api and cli docs routes to reference/Aug 13, 2024
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 13, 2024
edited
Loading

✅ Meticulous spotted zero visual differences across 1354 screens tested:view results.

Expected differences?Click here. Last updated for commit4f098d0. This comment will update as new commits are pushed.

@matifalimatifaliforce-pushed thematifali/move-refrences branch from5978a06 toa0efc99CompareAugust 13, 2024 14:52
@kylecarbs
Copy link
Member

I can make the redirect on coder.com whenever this is good to merge!

matifali and stirby reacted with thumbs up emoji

stirby

This comment was marked as resolved.

@stirby
Copy link
Collaborator

Nice work 👍

matifali reacted with heart emoji

@matifalimatifali merged commit48f29a1 intomainAug 13, 2024
35 of 36 checks passed
@matifalimatifali deleted the matifali/move-refrences branchAugust 13, 2024 15:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@stirbystirbystirby approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@matifalimatifali

Labels
docsArea: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@matifali@kylecarbs@stirby

[8]ページ先頭

©2009-2025 Movatter.jp