Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: redirect to the correct template page routes#14230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 9 commits intomainfromtemplates-redirect
Aug 12, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedAug 9, 2024•
edited
Loading

Closes#14068

  • /templates/org/template on a single-org deployment should remove the "/org" from the path
  • likewise, /templates/template on a multi-org deployment should redirect to /templates/the-default-org-name/template

preserves the subpage as well, albeit in a way I don't like. couldn't come up with anything better, but I have to admit it feels very hacky.

@aslilacaslilac changed the base branch frommain toshow-org-name-on-templates-pageAugust 9, 2024 20:10
@aslilacaslilac changed the titleTemplates redirect@aslilac chore: enforce correct template page routesAug 9, 2024
@aslilacaslilac changed the title@aslilac chore: enforce correct template page routeschore: enforce correct template page routesAug 9, 2024
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 9, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 213 of 1313 screens tested:view and approve differences detected.

Last updated for commitff0101b. This comment will update as new commits are pushed.

@aslilacaslilac changed the titlechore: enforce correct template page routeschore: redirect to the correct template page routesAug 9, 2024
Base automatically changed fromshow-org-name-on-templates-page tomainAugust 12, 2024 15:15
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks ok but since there are a few conditionals inside of the component I would create a test for each one.

@aslilacaslilac merged commit4c7132f intomainAug 12, 2024
29 checks passed
@aslilacaslilac deleted the templates-redirect branchAugust 12, 2024 19:12
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenh

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup frontend template routing
3 participants
@aslilac@BrunoQuaresma@Kira-Pilot
[8]ページ先頭
©2009-2025 Movatter.jp