- Notifications
You must be signed in to change notification settings - Fork927
feat: add delete custom role context menu button and modal#14228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
alwaysmeticulousbot commentedAug 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🤖 Meticulous spotted visual differences in 53 of 1313 screens tested:view and approve differences detected. Last updated for commit84524d0. This comment will update as new commits are pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
awesome!
| @@ -601,20 +601,20 @@ class ApiMethods { | |||
| }; | |||
| patchOrganizationRole = async ( | |||
| organizationId: string, | |||
| organization: string, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you copy-paste the doc comment a lot of these other org functions have? it's a minor thing, but I like the easily accessible reassurance that it can be the id or the name 😄
| role, | ||
| ); | ||
| return response.data; | ||
| }; | ||
| deleteOrganizationRole = async (organizationId: string, roleName: string) => { | ||
| deleteOrganizationRole = async (organization: string, roleName: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same for this function pls
0b9ed57 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.