Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: show summary if unable to edit org#14214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
code-asher merged 3 commits intomainfromasher/org-summary
Aug 9, 2024
Merged

Conversation

code-asher
Copy link
Member

@code-ashercode-asher commentedAug 7, 2024•
edited
Loading

This can happen if you can edit the members, for example, but not the organization settings. In this case you will see a new summary page instead of the edit form.

Stacked on#14193

It looks kinda lame, honestly, but probably less bad than an ineditable form, I think. Happy to take this in a different direction if we have some nicer-looking ideas.

screenshot

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 7, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 16 of 1313 screens tested:view and approve differences detected.

Last updated for commit920b210. This comment will update as new commits are pushed.

Base automatically changed fromasher/show-editable-orgs tomainAugust 9, 2024 06:18
@aslilac
Copy link
Member

oh, is graphite having some issue with stacking? just noticed all the merge conflict warnings, so my comments are probably out of date

This can happen if you can edit the members, for example, but not theorganization settings.  In this case you will see a new summary pageinstead of the edit form.
@code-asher
Copy link
MemberAuthor

oh, is graphite having some issue with stacking? just noticed all the merge conflict warnings, so my comments are probably out of date

Oh yeah sorry about that, I am not using Graphite so I had not pushed up a rebase yet. Sorry for the noise

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rad! lmk if you want more help setting up the storybook stuff. otherwise looks good.

code-asher reacted with thumbs up emojicode-asher reacted with heart emoji
@code-ashercode-asherforce-pushed theasher/org-summary branch 2 times, most recently from214c5f7 toe3ac9a2CompareAugust 9, 2024 21:14
@code-ashercode-asher merged commitba4186d intomainAug 9, 2024
30 checks passed
@code-ashercode-asher deleted the asher/org-summary branchAugust 9, 2024 21:31
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@code-ashercode-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@code-asher@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp