- Notifications
You must be signed in to change notification settings - Fork928
chore: move back to single audit log page#14212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5dec7da to1c95f1aComparealwaysmeticulousbot commentedAug 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🤖 Meticulous spotted visual differences in 254 of 1320 screens tested:view and approve differences detected. Last updated for commit39defe5. This comment will update as new commits are pushed. |
b811cfc toba8db22Compare7d30eab to95811ceCompareaslilac approved these changesAug 7, 2024
e5e6e1c tofdfe3acCompareFor now at least, we will have the one audit page at /audit which letsyou filter by organization.This also removes the need to do per-org audit permission checks.
fdfe3ac to39defe5Compare9a47ea1 intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
For now at least, we will have the one audit page at /audit which lets you filter by organization.
This removes the need to do per-org audit permission checks on the sidebar.
I also filtered the audit log dropdown to only show orgs for which you can audit, since before it showed any orgs you could read. Selecting one of those orgs would give you "no audit logs" which is misleading.
Stacked on: