- Notifications
You must be signed in to change notification settings - Fork928
refactor: refactor notification email templates#14208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| <body style="margin: 0; padding: 0; font-family: -apple-system, system-ui, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', sans-serif; color: #020617; background: #f8fafc;"> | ||
| <div style="max-width: 600px; margin: 20px auto; padding: 60px; border: 1px solid #e2e8f0; border-radius: 8px; background-color: #fff; text-align: left; font-size: 14px; line-height: 1.5;"> | ||
| <div style="text-align: center;"> | ||
| <img src="https://coder.com/coder-logo-300x300.png" alt="Coder Logo" style="width: 60px;" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we probably want a logo with our name in it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hm... I like the clean aspect of the icon, but I don't have a strong opinion. Why do you prefer the full logo instead of the icon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Our logo is not very recognisable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe for people who are not using the product, it could be less recognizable. For example, Vercel's logo is a generic triangle, but their users recognize it because they use the product, and I think it's the same for Coder. In the UI, for example, we only use the icon, and I think people know it's Coder. My preference would be to use only the icon for visual consistency and a cleaner look. What do you think,@stirby?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think it's important that folks know that these emails are coming from coder so that they don't trash them or mark them as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the footer, we include the Coder company name and the deployment URL. In my opinion, the subject is the most important information, and as I mentioned before, the notification emails will be sent to Coder users who are already familiar with our branding and context. However, since this isn't a blocker, I'll replace the icon with the horizontal logo that includes the name, as you suggested. We can revisit this discussion later if we think it adds value. Does that sound like a good plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
SGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
27b8f20 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Since many email clients do not support light/dark mode, we are moving forward with light mode as the default. However, we plan to add a configuration option later to let the user decide their preferred appearance.