Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add version information to default docs links#14205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

bcpeinhardt
Copy link
Contributor

This PR adds version information to the default docs links. If the user set's the docs link themselves it won't mess with it.
It also moves a helper function for getting embedded build info into utils and adds a little cache.

fixes#13369

@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 7, 2024
edited
Loading

🤖 Meticulous replayed 100 user sessions andtook 1261 visual snapshots. Meticulous has not yet run on238e995 of the main branch and so there was nothing to compare against.
If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons fornew pull requests after the next commit to the main branch.

Last updated for commit 52d60dc. This comment will update as new commits are pushed.

@matifalimatifali requested review froma team andaslilac and removed request fora teamAugust 8, 2024 13:08
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nice!

bcpeinhardtand others added2 commitsAugust 8, 2024 17:13
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
@bcpeinhardtbcpeinhardt merged commitd6c4d47 intomainAug 9, 2024
28 of 30 checks passed
@bcpeinhardtbcpeinhardt deleted the bcpeinhardt/add_version_information_to_docs_links branchAugust 9, 2024 01:20
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

@matifalimatifaliAwaiting requested review from matifali

Assignees

@bcpeinhardtbcpeinhardt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to versioned docs in the product
2 participants
@bcpeinhardt@aslilac

[8]ページ先頭

©2009-2025 Movatter.jp