Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: add a unit test to ensure correct behaviour with multiple replicas and rename LifecycleTicker to AutobuildTicker#1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/noissue/autobuild-exec-ha-test
May 13, 2022

Conversation

johnstcn
Copy link
Member

This PR adds another unit test toautobuild/executor to validate the correct behaviour when multiple coderd instances run in parallel.

Note: this only works if you use a "real" database, ascoderdtest.New by default uses a separate fake database instance per coderd.

@johnstcnjohnstcn requested a review froma teamMay 13, 2022 14:35
@johnstcnjohnstcn self-assigned thisMay 13, 2022
@codecov
Copy link

codecovbot commentedMay 13, 2022•
edited
Loading

Codecov Report

Merging#1420 (04d1cca) intomain (e6168ba) willincrease coverage by8.35%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1420      +/-   ##==========================================+ Coverage   58.80%   67.15%   +8.35%==========================================  Files         287      287                Lines       19331    19331                Branches      244      244              ==========================================+ Hits        11367    12982    +1615+ Misses       6747     5007    -1740- Partials     1217     1342     +125
FlagCoverage Δ
unittest-go-macos-latest54.15% <100.00%> (-0.02%)⬇️
unittest-go-postgres-65.64% <100.00%> (?)
unittest-go-ubuntu-latest56.58% <100.00%> (-0.03%)⬇️
unittest-go-windows-202252.57% <100.00%> (-0.02%)⬇️
unittest-js75.31% <ø> (ø)
Impacted FilesCoverage Δ
coderd/coderdtest/coderdtest.go98.27% <100.00%> (+4.44%)⬆️
peer/channel.go84.21% <0.00%> (-1.76%)⬇️
agent/agent.go65.28% <0.00%> (-0.62%)⬇️
provisioner/terraform/provision.go71.89% <0.00%> (-0.41%)⬇️
provisionerd/provisionerd.go76.03% <0.00%> (+0.26%)⬆️
coderd/provisionerdaemons.go63.31% <0.00%> (+0.50%)⬆️
coderd/workspaceagents.go56.04% <0.00%> (+0.69%)⬆️
coderd/templates.go64.24% <0.00%> (+1.55%)⬆️
peer/conn.go80.58% <0.00%> (+2.45%)⬆️
peerbroker/listen.go87.39% <0.00%> (+3.36%)⬆️
... and9 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatee6168ba...04d1cca. Read thecomment docs.

@johnstcnjohnstcn requested a review fromkylecarbsMay 13, 2022 14:54
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We should probably change the title to reflect what this changes, but LGTM!

@johnstcnjohnstcn changed the titlechore: add a unit test to ensure correct behaviour with multiple replicaschore: add a unit test to ensure correct behaviour with multiple replicas and rename LifecycleTicker to AutobuildTickerMay 13, 2022
@johnstcnjohnstcn merged commit4ab7a41 intomainMay 13, 2022
@johnstcnjohnstcn deleted the cj/noissue/autobuild-exec-ha-test branchMay 13, 2022 16:14
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* chore: add a unit test to ensure correct behaviour with multiple coderd replicas* nit: rename LifecycleTicker to AutobuildTicker
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@kylecarbs@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp