Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: improve notification template tests' resilience#14196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 2 commits intomainfromdk/template-version-param
Aug 7, 2024

Conversation

dannykopping
Copy link
Contributor

I added a nasty little func calledenumerateAllTemplates which enumerates all the notification templates defined incoderd/notifications/events.go. Using this, we can determine when we're missing test cases inTestNotificationTemplatesCanRender. I found two, and added those.

This is obviously suboptimal as a strategy: we should be using code-generation and linting. I've covered this incoder/internal#36. In the interim, let's not let the perfect get in the way of better test coverage.

Additionally, this adds the template update message to theTemplateWorkspaceAutoUpdated template so users will be informed of what changed when their template was auto-updated.

Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykoppingdannykopping merged commitc6076d2 intomainAug 7, 2024
28 checks passed
@dannykoppingdannykopping deleted the dk/template-version-param branchAugust 7, 2024 09:33
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 7, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@dannykopping@johnstcn@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp