NotificationsYou must be signed in to change notification settings
Fork927
Star10.1k

fix: only show editable orgs on deployment page#14193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

code-asher merged 14 commits intomainfromasher/show-editable-orgs

Aug 9, 2024

Merged

fix: only show editable orgs on deployment page#14193

code-asher merged 14 commits intomainfromasher/show-editable-orgs

Aug 9, 2024

Conversation

Copy link

Member

code-asher commentedAug 6, 2024

Also make sure the redirect from /organizations goes to an org that the user can edit, rather than always the default org.

github-actionsbot assignedcode-asher

Aug 6, 2024

Copy link

alwaysmeticulousbot commentedAug 6, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 528 of 1265 screens tested:view and approve differences detected.

_{Last updated for commitba22bc9. This comment will update as new commits are pushed.}

fix: only show editable orgs on deployment page

713b954

Also make sure the redirect from /organizations goes to an org that theuser can edit, rather than always the default org.

code-asher force-pushed theasher/show-editable-orgs branch fromf01285d to713b954Compare

August 6, 2024 23:36

code-asher requested a review fromaslilac

August 6, 2024 23:42

canEditOrganization was lying

9f39257

Copy link

Member

Emyrk commentedAug 7, 2024

If you cannotupdate the organization, should we showOrganization Summary?

Emyrk reviewed

Aug 7, 2024

View reviewed changes

site/src/api/queries/organizations.ts OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

code-asher commentedAug 7, 2024•
edited
Loading

If you cannot update the organization, should we show Organization Summary?

Yup I want to do this, I was going to do it in a separate PR though! For now it shows an ineditable form, as before.

Copy link

Member

Emyrk commentedAug 7, 2024

Yup I want to do this, I was going to do it in a separate PR though! For now it shows an ineditable form, as before.

Perfect 👍. Mainly just curious

Limit the number of org permission checks

475f6e2

We show the org on the sidebar if they can edit anything, and we showeach sub-link if they can view it, which means we were making both editand view permission checks.Instead, show each link if they can edit it (not just view), whichnegates the need for separate view permissions.Incidentally, this also reduces the number of checks we need to make forindividual pages, since some of them were only used on the sidebar.

code-asher force-pushed theasher/show-editable-orgs branch from92d15c5 to475f6e2Compare

August 7, 2024 20:27

This was referencedAug 7, 2024

chore: move back to single audit log page#14212

Merged

feat: show summary if unable to edit org#14214

Merged

Copy link

MemberAuthor