Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: only show valid organizations inCreateTemplateForm#14174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 3 commits intomainfromcheck-create-template-permissions
Aug 6, 2024

Conversation

aslilac
Copy link
Member

Closes#14004

Hide any organizations that the user might have view permissions for, but not permission to create a template

hide any organizations that the user might have view permissions for, but not permission to create a template
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 5, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 82 of 735 screens tested:view and approve differences detected.

Last updated for commit37b84eb. This comment will update as new commits are pushed.

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Permission LG 👍

{"object":{"resource_type":"template","organization_id:"<org_id>   },"action":"create"}

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Code looks good. I just have one minor question. Going to QA this right now 👀

@BrunoQuaresma
Copy link
Collaborator

@aslilac@Emyrk I think I found a bug with permissions. After creating a new user and adding this user into an org as admin, this user is not able to do anything related to templates.

Screen.Recording.2024-08-06.at.12.51.31.mov

@Emyrk
Copy link
Member

@aslilac@Emyrk I think I found a bug with permissions. After creating a new user and adding this user into an org as admin, this user is not able to do anything related to templates.

Screen.Recording.2024-08-06.at.12.51.31.mov

You are right, it is this call:http://localhost:3000/api/v2/organizations/default/templates/examples. Basically, anorg-admin can make templates, and for some reason we query for the default template examples on the/templates page.

But we only query it for the primary org, which is going to fail for the org-admin in the second org.

@aslilacaslilac merged commit3b53f5a intomainAug 6, 2024
34 checks passed
@aslilacaslilac deleted the check-create-template-permissions branchAugust 6, 2024 18:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When creating a template, check authorization to determine the organizations where a user can create a template
3 participants
@aslilac@BrunoQuaresma@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp