Aug 5, 2024 · Aug 5, 2024 · Aug 5, 2024 · Aug 5, 2024 · Aug 5, 2024
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/users.go b/coderd/users.go
 // @Security CoderSessionToken
 // @Tags Users
 // @Param user path string true "User ID, name, or me"
 // @Success204
 // @Success200
 // @Router /users/{user} [delete]
 func (api *API) deleteUser(rw http.ResponseWriter, r *http.Request) {
 ctx := r.Context()
 }
 }

 rw.WriteHeader(http.StatusNoContent)
 httpapi.Write(ctx, rw, http.StatusOK, codersdk.Response{
 Message: "User has been deleted!",
 })
 }

 // Returns the parameterized user requested. All validation
diff --git a/codersdk/users.go b/codersdk/users.go
 return err
 }
 defer res.Body.Close()
 if res.StatusCode != http.StatusNoContent {
 if res.StatusCode != http.StatusOK {
 return ReadBodyAsError(res)
 }
 return nil
diff --git a/docs/api/users.md b/docs/api/users.md
Original file line number	Diff line number	Diff line change
Expand Up		@@ -513,7 +513,7 @@ func (api API) postUser(rw http.ResponseWriter, r http.Request) {
		// @Security CoderSessionToken
		// @Tags Users
		// @Param user path string true "User ID, name, or me"
		// @Success204
		// @Success200
Copy link Member aslilacAug 5, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. also this should probably specify`codersdk.Response`
		// @Router /users/{user} [delete]
		func (api API) deleteUser(rw http.ResponseWriter, r http.Request) {
		ctx := r.Context()
Expand DownExpand Up		@@ -588,7 +588,9 @@ func (api API) deleteUser(rw http.ResponseWriter, r http.Request) {
		}
		}

		rw.WriteHeader(http.StatusNoContent)
		httpapi.Write(ctx, rw, http.StatusOK, codersdk.Response{
		Message: "User has been deleted!",
		})
		}

		// Returns the parameterized user requested. All validation
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -309,7 +309,7 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error {
		return err
		}
		defer res.Body.Close()
		if res.StatusCode != http.StatusNoContent {
Copy link Member aslilacAug 5, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. did a version get released with the other status code? should this be`res.StatusCode != http.StatusNoContent && res.StatusCode != http.StatusOK`? Copy link MemberAuthor EmyrkAug 5, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. you are right. I didn't think about that when I reverted. Let me throw up another 🤦
		if res.StatusCode != http.StatusOK {
		return ReadBodyAsError(res)
		}
		return nil
Expand Down