- Notifications
You must be signed in to change notification settings - Fork926
chore: revert status code change for delete users endpoint#14168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b80d995 intomainUh oh!
There was an error while loading.Please reload this page.
| @@ -309,7 +309,7 @@ func (c *Client) DeleteUser(ctx context.Context, id uuid.UUID) error { | |||
| returnerr | |||
| } | |||
| deferres.Body.Close() | |||
| ifres.StatusCode!=http.StatusNoContent { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
did a version get released with the other status code? should this beres.StatusCode != http.StatusNoContent && res.StatusCode != http.StatusOK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you are right. I didn't think about that when I reverted. Let me throw up another 🤦
| @@ -513,7 +513,7 @@ func (api *API) postUser(rw http.ResponseWriter, r *http.Request) { | |||
| // @Security CoderSessionToken | |||
| // @Tags Users | |||
| // @Param user path string true "User ID, name, or me" | |||
| // @Success204 | |||
| // @Success200 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
also this should probably specifycodersdk.Response
Revert from#13870