Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: remove global organization id state#14135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 12 commits intomainfromkorgpolish
Aug 5, 2024
Merged

chore: remove global organization id state#14135

aslilac merged 12 commits intomainfromkorgpolish
Aug 5, 2024

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedAug 2, 2024•
edited
Loading

Closes#14057

  • RemovesorganizationId from the dashboard provider
  • Cleans up some more navigation code
  • Shows templates from all organizations on /templates now
  • Fix some bugs around creating and viewing workspaces, all related to using the wrong organization ID

@aslilacaslilac requested review froma team andjaaydenh and removed request fora teamAugust 2, 2024 18:26
@alwaysmeticulousalwaysmeticulous
Copy link

alwaysmeticulousbot commentedAug 2, 2024•
edited
Loading

🤖 Meticulous spotted visual differences in 458 of 944 screens tested:view and approve differences detected.

Last updated for commitf7879a1. This comment will update as new commits are pushed.

@aslilacaslilac requested review froma team andBrunoQuaresmaAugust 2, 2024 22:25
dashboard.experiments.includes("multi-organization") &&
selectFeatureVisibility(dashboard.entitlements).multiple_organizations;

return hasMultipleOrganizations || organizationsEnabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If the deployment has multiple organizations. but the organization's feature is not enabled, should this return true? The use case I'm seeing is a deployment that had access to enterprise and does not have it anymore after the trial.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, that's the goal. We don't want swaths of the app to become unaccessible because they're in the final stages of renewing a contract with us.

Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good, and I think we have good coverage around the affected components. I'm approving it, and I will run a quick check afterward.

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commentedAug 5, 2024•
edited
Loading

To run this in the new workspace version after upgrading to NodeJS 20+, we have to rebase this branch withmain, but I will leave this up to you since I don't want to disrupt your flow.

@aslilacaslilac merged commitefbd625 intomainAug 5, 2024
30 checks passed
@aslilacaslilac deleted the korgpolish branchAugust 5, 2024 16:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenhjaaydenh was automatically assigned from coder/ts

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot view workspaces in another organization
2 participants
@aslilac@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp