Aug 5, 2024 · Aug 2, 2024 · Aug 2, 2024
diff --git a/coderd/database/dbauthz/dbauthz.go b/coderd/database/dbauthz/dbauthz.go
 }

 func (q *querier) GetAuditLogsOffset(ctx context.Context, arg database.GetAuditLogsOffsetParams) ([]database.GetAuditLogsOffsetRow, error) {
 // Shortcut if the user is an owner. The SQL filter is noticeable,
 // and this is an easy win for owners. Which is the common case.
 err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceAuditLog)
 if err == nil {
 return q.db.GetAuditLogsOffset(ctx, arg)
 }

 prep, err := prepareSQLFilter(ctx, q.auth, policy.ActionRead, rbac.ResourceAuditLog.Type)
 if err != nil {
 return nil, xerrors.Errorf("(dev error) prepare sql filter: %w", err)
diff --git a/coderd/database/dbauthz/dbauthz_test.go b/coderd/database/dbauthz/dbauthz_test.go
 _ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
 check.Args(database.GetAuditLogsOffsetParams{
 LimitOpt: 10,
 }).Asserts()
 }).Asserts(rbac.ResourceAuditLog, policy.ActionRead)
 }))
 s.Run("GetAuthorizedAuditLogsOffset", s.Subtest(func(db database.Store, check *expects) {
 _ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
 _ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
 check.Args(database.GetAuditLogsOffsetParams{
 LimitOpt: 10,
 }, emptyPreparedAuthorized{}).Asserts()
 }, emptyPreparedAuthorized{}).Asserts(rbac.ResourceAuditLog, policy.ActionRead)
 }))
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1248,6 +1248,13 @@ func (q *querier) GetApplicationName(ctx context.Context) (string, error) {
		}

		func (q *querier) GetAuditLogsOffset(ctx context.Context, arg database.GetAuditLogsOffsetParams) ([]database.GetAuditLogsOffsetRow, error) {
		// Shortcut if the user is an owner. The SQL filter is noticeable,
		// and this is an easy win for owners. Which is the common case.
		err := q.authorizeContext(ctx, policy.ActionRead, rbac.ResourceAuditLog)
		if err == nil {
		return q.db.GetAuditLogsOffset(ctx, arg)
		}

		prep, err := prepareSQLFilter(ctx, q.auth, policy.ActionRead, rbac.ResourceAuditLog.Type)
		if err != nil {
		return nil, xerrors.Errorf("(dev error) prepare sql filter: %w", err)
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -266,14 +266,14 @@ func (s *MethodTestSuite) TestAuditLogs() {
		_ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
		check.Args(database.GetAuditLogsOffsetParams{
		LimitOpt: 10,
		}).Asserts()
		}).Asserts(rbac.ResourceAuditLog, policy.ActionRead)
		}))
		s.Run("GetAuthorizedAuditLogsOffset", s.Subtest(func(db database.Store, check *expects) {
		_ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
		_ = dbgen.AuditLog(s.T(), db, database.AuditLog{})
		check.Args(database.GetAuditLogsOffsetParams{
		LimitOpt: 10,
		}, emptyPreparedAuthorized{}).Asserts()
		}, emptyPreparedAuthorized{}).Asserts(rbac.ResourceAuditLog, policy.ActionRead)
		}))
		}

Expand Down