Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add audit diffing for all user editable types#1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
coadler merged 2 commits intomainfromcolin/audit-all-types
May 16, 2022

Conversation

coadler
Copy link
Contributor

@coadlercoadler commentedMay 12, 2022•
edited
Loading

Resolves#467
Resolves#476

Adds the rest of the database types that are directly editable by users to the audit table. It also adds tests for each type to ensure the audit information is kept up-to-date.

@coadlercoadler self-assigned thisMay 12, 2022
@codecov
Copy link

codecovbot commentedMay 12, 2022•
edited
Loading

Codecov Report

Merging#1413 (2dba7ed) intomain (75a5877) willincrease coverage by0.15%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##             main    #1413      +/-   ##==========================================+ Coverage   67.08%   67.24%   +0.15%==========================================  Files         282      287       +5       Lines       19008    19233     +225       Branches      241      241              ==========================================+ Hits        12752    12933     +181- Misses       4935     4967      +32- Partials     1321     1333      +12
FlagCoverage Δ
unittest-go-macos-latest54.33% <100.00%> (?)
unittest-go-postgres-65.75% <100.00%> (-0.03%)⬇️
unittest-go-ubuntu-latest56.59% <100.00%> (+0.04%)⬆️
unittest-go-windows-202252.61% <100.00%> (?)
unittest-js74.65% <ø> (ø)
Impacted FilesCoverage Δ
coderd/audit/table.go77.77% <ø> (ø)
coderd/audit/diff.go88.88% <100.00%> (+2.32%)⬆️
provisionersdk/serve.go35.13% <0.00%> (-8.11%)⬇️
cli/cliui/provisionerjob.go76.42% <0.00%> (-2.15%)⬇️
provisionerd/provisionerd.go75.50% <0.00%> (-1.88%)⬇️
coderd/provisionerdaemons.go63.81% <0.00%> (ø)
pty/start_windows.go66.95% <0.00%> (ø)
pty/pty_windows.go70.14% <0.00%> (ø)
agent/usershell/usershell_darwin.go100.00% <0.00%> (ø)
... and11 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update75a5877...2dba7ed. Read thecomment docs.

@coadlercoadler requested a review fromkylecarbsMay 12, 2022 21:10
@missknissmisskniss added this to theV2 Beta milestoneMay 15, 2022
@coadlercoadlerforce-pushed thecolin/audit-all-types branch from65de9ba toa17dafcCompareMay 16, 2022 15:54
Copy link
Member

@kylecarbskylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@coadlercoadler merged commite990a9a intomainMay 16, 2022
@coadlercoadler deleted the colin/audit-all-types branchMay 16, 2022 16:20
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@coadlercoadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Create tests for audit logging that are decoupled from HTTP API testing Bring audit diffing out of individual structs and into a centralized package
4 participants
@coadler@johnstcn@kylecarbs@misskniss
[8]ページ先頭
©2009-2025 Movatter.jp